Skip to content
This repository was archived by the owner on Jul 24, 2020. It is now read-only.

Commit 38f1ec7

Browse files
author
Sydney Young
committed
small refactor of service object
1 parent 435ba14 commit 38f1ec7

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

lib/reservation_creator.rb

+1-9
Original file line numberDiff line numberDiff line change
@@ -28,21 +28,13 @@ def error
2828
end
2929

3030
def needs_notes?
31-
(request? && !valid_request?) || (override? && !valid_override?)
32-
end
33-
34-
def valid_request?
35-
request? && !notes.blank?
31+
(request? || override?) && notes.blank?
3632
end
3733

3834
def override?
3935
override && !cart_errors.blank?
4036
end
4137

42-
def valid_override?
43-
override? && !notes.blank?
44-
end
45-
4638
def reservation_transaction
4739
result = {}
4840
Reservation.transaction do

0 commit comments

Comments
 (0)