Merge pull request #1073 from YaleSTC/1072_cleanup_before_filter

#1072 Cleanup Before Filter

Author: squidgetx

app/controllers/application_controller.rb

@@ -223,13 +223,6 @@ def empty_cart
     end
   end
 
-  def require_login
-    if current_user.nil?
-      flash[:error] = "Sorry, that action requires you to log in."
-      redirect_to root_path
-    end
-  end
-
   def terms_of_service
     @tos = @app_configs.terms_of_service
     render 'terms_of_service/index'

app/controllers/reservations_controller.rb

@@ -2,7 +2,6 @@ class ReservationsController < ApplicationController
 
   load_and_authorize_resource
 
-  before_action :require_login, only: [:index, :show]
   before_action :set_reservation, only: [:show, :edit, :update, :destroy,
      :checkout_email, :checkin_email, :renew, :review, :approve_request, :deny_request]
   before_action :set_user, only: [:manage, :current, :checkout]

spec/controllers/application_controller_spec.rb

@@ -3,7 +3,6 @@
 class TestController < ApplicationController
   before_filter :require_admin, only: [:method_requiring_admin]
   before_filter :require_checkout_person, only: [:method_requiring_checkout_person]
-  before_filter :require_login, only: [:method_requiring_login]
   before_filter :require_user_or_checkout_person, only: [:method_requiring_user_or_checkout_person]
   before_filter :require_user, only: [:method_requiring_user]
 
@@ -25,9 +24,6 @@ def method_requiring_admin
   def method_requiring_checkout_person
     render :text => 'checkout person required!'
   end
-  def method_requiring_login
-    render :text => 'you must be logged in!'
-  end
   def method_requiring_user_or_checkout_person
     render :text => 'are you a user or a checkout person?'
   end