fix: add eslint-plugin-perfectionist, make eslint report all errors & warnings on ALL files during build

Author: kristof-mattei

.github/workflows/build.yml

@@ -183,6 +183,9 @@ jobs:
         uses: ataylorme/eslint-annotate-action@d57a1193d4c59cbfbf3f86c271f42612f9dbd9e9 # 3.0.0
         with:
           report-json: reports/lint-report.json
+          fail-on-error: true
+          fail-on-warning: true
+          only-pr-files: false
 
       - name: Fail if lint failed
         shell: bash

eslint.config.mjs

@@ -10,10 +10,12 @@ import tsParser from "@typescript-eslint/parser";
 import love from "eslint-config-love";
 import importPlugin from "eslint-plugin-import-x";
 import nPlugin from "eslint-plugin-n";
+import perfectionist from "eslint-plugin-perfectionist";
 import prettier from "eslint-plugin-prettier/recommended";
 import promise from "eslint-plugin-promise";
 
 import eslintPluginUnicorn from "eslint-plugin-unicorn";
+import globals from "globals";
 import tseslint from "typescript-eslint";
 
 const __filename = fileURLToPath(import.meta.url);
@@ -161,6 +163,7 @@ export default tseslint.config(
             "import-x": importPlugin,
             n: nPlugin,
             promise,
+            perfectionist,
         },
         settings: {
             "import-x/resolver": {
@@ -226,10 +229,10 @@ export default tseslint.config(
                     selector: "enumMember",
                 },
             ],
-            "@typescript-eslint/no-empty-interface": ["error"],
             "@typescript-eslint/no-empty-object-type": ["error"],
             "@typescript-eslint/no-explicit-any": ["error", { fixToUnknown: true, ignoreRestArgs: false }],
             "@typescript-eslint/no-extraneous-class": ["error"],
+            "@typescript-eslint/no-magic-numbers": ["off"],
             "@typescript-eslint/no-shadow": ["error"],
             "@typescript-eslint/no-unused-expressions": [
                 "error",
@@ -257,7 +260,6 @@ export default tseslint.config(
             "@typescript-eslint/prefer-string-starts-ends-with": ["error"],
             "@typescript-eslint/promise-function-async": ["off"],
             "@typescript-eslint/require-await": ["error"],
-            "@typescript-eslint/sort-type-constituents": ["error"],
 
             "@typescript-eslint/unified-signatures": ["error"],
 
@@ -270,13 +272,22 @@ export default tseslint.config(
             "n/no-new-require": ["error"],
             "n/no-path-concat": ["error"],
             "n/process-exit-as-throw": ["error"],
+
+            "perfectionist/sort-intersection-types": ["error"],
+            "perfectionist/sort-union-types": ["error"],
+
             "promise/param-names": ["error"],
         },
     },
 
     {
         extends: [tseslint.configs.disableTypeChecked],
-        files: ["*.mjs"],
+        files: ["*.js", "*.mjs"],
+        languageOptions: {
+            globals: {
+                ...globals.node,
+            },
+        },
         rules: {},
     },
     prettier,

package-lock.json

@@ -54,12 +54,13 @@
         "conventional-changelog-conventionalcommits": "8.0.0",
         "dependency-cruiser": "16.4.1",
         "eslint": "8.57.0",
-        "eslint-config-love": "64.0.0",
+        "eslint-config-love": "66.0.0",
         "eslint-config-prettier": "9.1.0",
         "eslint-import-resolver-node": "0.3.9",
         "eslint-import-resolver-typescript": "3.6.3",
         "eslint-plugin-import-x": "4.2.1",
         "eslint-plugin-n": "17.10.2",
+        "eslint-plugin-perfectionist": "3.6.0",
         "eslint-plugin-prettier": "5.2.1",
         "eslint-plugin-promise": "7.1.0",
         "eslint-plugin-unicorn": "55.0.0",

package.json

@@ -6,7 +6,7 @@ import type { AnnotationWithMessageAndLevel, CargoMessage, MaybeCargoMessage, St
 import { AnnotationLevel } from "@/schema";
 
 export class OutputParser {
-    private readonly _workingDirectory: string | null;
+    private readonly _workingDirectory: null | string;
     private readonly _uniqueAnnotations: Map<string, AnnotationWithMessageAndLevel>;
     private readonly _stats: Stats;
 

src/output-parser.ts

@@ -15,7 +15,7 @@ export interface AnnotationWithMessageAndLevel {
 export interface MaybeCargoMessage {
     reason: string;
     message?: {
-        code?: string | null;
+        code?: null | string;
         level: string;
         message: string;
         rendered: string;