@@ -73,7 +73,7 @@ Fixing issues and working stories
73
73
Review the `issues
74
74
list <https://github.com/hyperledger/fabric/issues> `__ and find
75
75
something that interests you. You could also check the
76
- `"help-wanted" <https://jira.hyperledger.org/issues/?jql=project%20%3D%20Fabric%20AND%20labels%20%3D%20help-wanted >`__
76
+ `"help-wanted" <https://jira.hyperledger.org/issues/?filter=10147 >`__
77
77
list. It is wise to start with something relatively straight forward and
78
78
achievable, and that no one is already assigned. If no one is assigned,
79
79
then assign the issue to yourself. Please be considerate and rescind the
@@ -140,7 +140,7 @@ What makes a good change request?
140
140
- Minimize the lines of code per CR. Why? Maintainers have day jobs,
141
141
too. If you send a 1,000 or 2,000 LOC change, how long do you think
142
142
it takes to review all of that code? Keep your changes to < 200-300
143
- LOC if possible. If you have a larger change, decompose it into
143
+ LOC, if possible. If you have a larger change, decompose it into
144
144
multiple independent changess. If you are adding a bunch of new
145
145
functions to fulfill the requirements of a new capability, add them
146
146
separately with their tests, and then write the code that uses them
@@ -150,12 +150,24 @@ What makes a good change request?
150
150
bunch of generated code (protobufs, etc.). Again, there can be
151
151
exceptions.
152
152
153
+ Note: large change requests, e.g. those with more than 300 LOC are more likely
154
+ than not going to receive a -2, and you'll be asked to refactor the change
155
+ to conform with this guidance.
156
+
157
+ - Do not stack change requests (e.g. submit a CR from the same local branch
158
+ as your previous CR) unless they are related. This will minimize merge
159
+ conflicts and allow changes to be merged more quickly. If you stack requests
160
+ your subsequent requests may be held up because of review comments in the
161
+ preceding requests.
162
+
153
163
- Write a meaningful commit message. Include a meaningful 50 (or less)
154
- character title, followed by a blank line, followed my a more
155
- comprehensive description of the change. Be sure to include the JIRA
164
+ character title, followed by a blank line, followed by a more
165
+ comprehensive description of the change. Each change MUST include the JIRA
156
166
identifier corresponding to the change (e.g. [FAB-1234]). This can be
157
167
in the title but should also be in the body of the commit message.
158
168
169
+ Note that Gerrit will automatically create a hyperlink to the JIRA item.
170
+
159
171
e.g.
160
172
161
173
::
@@ -177,7 +189,7 @@ Be sure to check out the language-specific `style
177
189
guides <Style-guides/go-style.md> `__ before making any changes. This
178
190
will ensure a smoother review.
179
191
180
- Communication
192
+ Communication
181
193
--------------
182
194
183
195
We use `RocketChat <https://chat.hyperledger.org/ >`__ for communication
0 commit comments