Skip to content

Commit 1405e27

Browse files
author
Jason Yellick
committed
[FAB-2367] Remove unused orderer yaml parameters
https://jira.hyperledger.org/browse/FAB-2367 The orderer.yaml file contains a QueueSize and WindowSize parameter which invites people to tweak these parameters to attempt to optimize performance. However, they no longer have any effect on the system and the only place they are referenced is in the config. This CR removes them. Change-Id: Ida695c94d447b93a177786506579830575c49a79 Signed-off-by: Jason Yellick <[email protected]>
1 parent 5455c58 commit 1405e27

File tree

2 files changed

+0
-18
lines changed

2 files changed

+0
-18
lines changed

orderer/localconfig/config.go

-10
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,6 @@ const Prefix string = "ORDERER"
4242
// General contains config which should be common among all orderer types
4343
type General struct {
4444
LedgerType string
45-
QueueSize uint32
46-
MaxWindowSize uint32
4745
ListenAddress string
4846
ListenPort uint16
4947
TLS TLS
@@ -145,8 +143,6 @@ type TopLevel struct {
145143
var defaults = TopLevel{
146144
General: General{
147145
LedgerType: "ram",
148-
QueueSize: 1000,
149-
MaxWindowSize: 1000,
150146
ListenAddress: "127.0.0.1",
151147
ListenPort: 7050,
152148
GenesisMethod: "provisional",
@@ -202,12 +198,6 @@ func (c *TopLevel) completeInitialization() {
202198
case c.General.LedgerType == "":
203199
logger.Infof("General.LedgerType unset, setting to %s", defaults.General.LedgerType)
204200
c.General.LedgerType = defaults.General.LedgerType
205-
case c.General.QueueSize == 0:
206-
logger.Infof("General.QueueSize unset, setting to %s", defaults.General.QueueSize)
207-
c.General.QueueSize = defaults.General.QueueSize
208-
case c.General.MaxWindowSize == 0:
209-
logger.Infof("General.MaxWindowSize unset, setting to %s", defaults.General.MaxWindowSize)
210-
c.General.MaxWindowSize = defaults.General.MaxWindowSize
211201
case c.General.ListenAddress == "":
212202
logger.Infof("General.ListenAddress unset, setting to %s", defaults.General.ListenAddress)
213203
c.General.ListenAddress = defaults.General.ListenAddress

orderer/orderer.yaml

-8
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,6 @@ General:
1313
# Available types are "ram", "file".
1414
LedgerType: ram
1515

16-
# Queue Size: The maximum number of messages to allow pending from a gRPC
17-
# client.
18-
QueueSize: 10
19-
20-
# Max Window Size: The maximum number of messages to for the orderer Deliver
21-
# to allow before acknowledgement must be received from the client.
22-
MaxWindowSize: 1000
23-
2416
# Listen address: The IP on which to bind to listen
2517
ListenAddress: 127.0.0.1
2618

0 commit comments

Comments
 (0)