Skip to content

Commit 2b8c0aa

Browse files
author
Luis Sanchez
committed
[FAB-4251] Only support TLS >= 1.2 to Kafka
Change-Id: Ib9fd3573e12e5f5916e58d7e96792c95af496ceb Signed-off-by: Luis Sanchez <[email protected]>
1 parent a01b2f9 commit 2b8c0aa

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

orderer/kafka/util.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ func newBrokerConfig(kafkaVersion sarama.KafkaVersion, chosenStaticPartition int
4848
brokerConfig.Net.TLS.Config = &tls.Config{
4949
Certificates: []tls.Certificate{keyPair},
5050
RootCAs: rootCAs,
51-
MinVersion: 0, // TLS 1.0 (no SSL support)
51+
MinVersion: tls.VersionTLS12,
5252
MaxVersion: 0, // Latest supported TLS version
5353
}
5454
}

orderer/kafka/util_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ limitations under the License.
1717
package kafka
1818

1919
import (
20+
"crypto/tls"
2021
"testing"
2122

2223
"github.com/Shopify/sarama"
@@ -132,7 +133,7 @@ func TestTLSConfigEnabled(t *testing.T) {
132133
assert.Len(t, config.Net.TLS.Config.Certificates, 1)
133134
assert.Len(t, config.Net.TLS.Config.RootCAs.Subjects(), 1)
134135
assert.Equal(t, uint16(0), config.Net.TLS.Config.MaxVersion)
135-
assert.Equal(t, uint16(0), config.Net.TLS.Config.MinVersion)
136+
assert.Equal(t, uint16(tls.VersionTLS12), config.Net.TLS.Config.MinVersion)
136137
}
137138

138139
func TestTLSConfigDisabled(t *testing.T) {

0 commit comments

Comments
 (0)