Skip to content

Commit 45e6cf3

Browse files
Revert 721- Prevent Jenkins build from cleaning baseimage
Revert commit 84d1234 which was inadvertently merged despite there being outstanding concerns. Change-Id: Idbe47347e1008da28cd7730947c7225e74a12c5b Signed-off-by: Christopher Ferris <[email protected]>
1 parent 2552dd0 commit 45e6cf3

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

Makefile

+2-10
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,13 @@
2828
# - gotools - installs go tools like golint
2929
# - linter - runs all code checks
3030
# - images[-clean] - ensures all docker images are available[/cleaned]
31-
# - images-scrub - ensures all docker images are cleaned including fabric-baseimage
3231
# - peer-image[-clean] - ensures the peer-image is available[/cleaned] (for behave, etc)
3332
# - membersrvc-image[-clean] - ensures the membersrvc-image is available[/cleaned] (for behave, etc)
3433
# - protos - generate all protobuf artifacts based on .proto files
3534
# - node-sdk - builds the node.js client sdk
3635
# - node-sdk-unit-tests - runs the node.js client sdk unit tests
3736
# - clean - cleans the build area
3837
# - dist-clean - superset of 'clean' that also removes persistent state
39-
# - dist-scrub - superset of 'clean' that also removes fabric-baseimage
4038

4139
PROJECT_NAME = hyperledger/fabric
4240
BASE_VERSION = 0.6.0
@@ -71,8 +69,7 @@ BASEIMAGE_DEPS = $(shell git ls-files images/base scripts/provision)
7169

7270
JAVASHIM_DEPS = $(shell git ls-files core/chaincode/shim/java)
7371
PROJECT_FILES = $(shell git ls-files)
74-
SUBIMAGES = src ccenv peer membersrvc javaenv
75-
IMAGES = base $(SUBIMAGES)
72+
IMAGES = base src ccenv peer membersrvc javaenv
7673

7774
all: peer membersrvc checks
7875

@@ -254,19 +251,14 @@ src-image-clean: ccenv-image-clean peer-image-clean membersrvc-image-clean
254251
-docker images -q $(PROJECT_NAME)-$(TARGET) | xargs -r docker rmi -f
255252
-@rm -rf build/image/$(TARGET) ||:
256253

257-
images-clean: $(patsubst %,%-image-clean, $(SUBIMAGES))
258-
259-
images-scrub: $(patsubst %,%-image-clean, $(IMAGES))
254+
images-clean: $(patsubst %,%-image-clean, $(IMAGES))
260255

261256
.PHONY: $(SUBDIRS:=-clean)
262257
$(SUBDIRS:=-clean):
263258
cd $(patsubst %-clean,%,$@) && $(MAKE) clean
264259

265260
.PHONY: clean
266261
clean: images-clean $(filter-out gotools-clean, $(SUBDIRS:=-clean))
267-
268-
.PHONY: scrub
269-
scrub: images-scrub $(filter-out gotools-clean, $(SUBDIRS:=-clean))
270262
-@rm -rf build ||:
271263

272264
.PHONY: dist-clean

0 commit comments

Comments
 (0)