Skip to content

Commit 4f03b14

Browse files
author
Srinivasan Muralidharan
committed
FAB-2557 remove overlapping chaincode UTs
https://jira.hyperledger.org/browse/FAB-2557 Skipped some chaincode tests with rationale in comments. Will help reduce UT time. Change-Id: I74082c97fc9d474b35fe60edfe66fff4eca26f90 Signed-off-by: Srinivasan Muralidharan <[email protected]>
1 parent 3eaccbd commit 4f03b14

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

core/chaincode/exectransaction_test.go

+7
Original file line numberDiff line numberDiff line change
@@ -471,13 +471,17 @@ func _(chainID string, _ string) error {
471471

472472
// Test deploy of a transaction
473473
func TestExecuteDeployTransaction(t *testing.T) {
474+
//chaincoe is deployed as part of many tests. No need for a separate one for this
475+
t.Skip()
474476
chainID := util.GetTestChainID()
475477

476478
executeDeployTransaction(t, chainID, "example01", "github.com/hyperledger/fabric/examples/chaincode/go/chaincode_example01")
477479
}
478480

479481
// Test deploy of a transaction with a GOPATH with multiple elements
480482
func TestGopathExecuteDeployTransaction(t *testing.T) {
483+
//this is no longer critical as chaincode is assembled in the client side (SDK)
484+
t.Skip()
481485
chainID := util.GetTestChainID()
482486

483487
// add a trailing slash to GOPATH
@@ -1041,6 +1045,9 @@ func TestGetEvent(t *testing.T) {
10411045
// Test the execution of a chaincode that queries another chaincode
10421046
// example02 implements "query" as a function in Invoke. example05 calls example02
10431047
func TestChaincodeQueryChaincodeUsingInvoke(t *testing.T) {
1048+
//this is essentially same as the ChaincodeInvokeChaincode now that
1049+
//we don't distinguish between Invoke and Query (there's no separate "Query")
1050+
t.Skip()
10441051
chainID := util.GetTestChainID()
10451052

10461053
var peerLis net.Listener

core/chaincode/multichains_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ import (
2626
)
2727

2828
func TestExecuteInvokeOnManyChains(t *testing.T) {
29-
chains := []string{"chain1", "chain2", "chain3", "chain4"}
29+
//lets use 2 chains to test multi chains
30+
chains := []string{"chain1", "chain2"}
3031
lis, err := initPeer(chains...)
3132
if err != nil {
3233
t.Fail()

0 commit comments

Comments
 (0)