Skip to content

Commit 552cbfe

Browse files
committed
[FAB-3289] Fix multi-broker Kafka BDD test
This changeset corrects the timing assumptions and orderer references that prevented the multi-broker Kafka test (last configuration on the "Orderer Options" Examples table) from passing. Change-Id: I8ec88f64fd3c899d3c3de8a77cead5eac0df8940 Signed-off-by: Kostas Christidis <[email protected]>
1 parent 689b8f4 commit 552cbfe

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

bddtests/features/bootstrap.feature

+9-10
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ Feature: Bootstrap
149149

150150
And the user "dev0Org0" using cert alias "dev0Org0App1" broadcasts ConfigUpdate Tx "configUpdateTx1" to orderer "<orderer0>" to create channel "com.acme.blockchain.jdoe.Channel1"
151151

152-
# Sleep as the deliver takes a bit to have the first block ready
152+
# Sleep as the local orderer ledger needs to create the block that corresponds to the start number of the seek request
153153
And I wait "<BroadcastWaitTime>" seconds
154154

155155
When user "dev0Org0" using cert alias "dev0Org0App1" connects to deliver function on orderer "<orderer0>"
@@ -257,8 +257,8 @@ Feature: Bootstrap
257257

258258
And the user "configAdminPeerOrg0" broadcasts transaction "instantiateTx1" to orderer "<orderer1>" on channel "com.acme.blockchain.jdoe.Channel1"
259259

260-
# Sleep as the deliver takes a bit to have the first block ready
261-
And I wait "2" seconds
260+
# Sleep as the local orderer ledger needs to create the block that corresponds to the start number of the seek request
261+
And I wait "<BroadcastWaitTime>" seconds
262262

263263
And user "configAdminPeerOrg0" using cert alias "config-admin-cert" connects to deliver function on orderer "<orderer0>"
264264

@@ -268,10 +268,9 @@ Feature: Bootstrap
268268

269269
Then user "configAdminPeerOrg0" should get a delivery "deliveredInstantiateTx1Block" from "<orderer0>" of "1" blocks with "1" messages within "1" seconds
270270

271-
# Sleep as the deliver takes a bit to have the first block ready
271+
# Sleep to allow for chaincode instantiation on the peer
272272
And I wait "3" seconds
273273

274-
275274
# Entry point for invoking on an existing channel
276275
When user "dev0Org0" creates a chaincode invocation spec "querySpec1" using spec "cc_spec" with input:
277276
| funcName | arg1 |
@@ -323,8 +322,8 @@ Feature: Bootstrap
323322

324323
And the user "dev0Org0" broadcasts transaction "invokeTx1" to orderer "<orderer2>" on channel "com.acme.blockchain.jdoe.Channel1"
325324

326-
# Sleep as the deliver takes a bit to have the first block ready
327-
And I wait "3" seconds
325+
# Sleep as the local orderer ledger needs to create the block that corresponds to the start number of the seek request
326+
And I wait "<BroadcastWaitTime>" seconds
328327

329328
And user "dev0Org0" sends deliver a seek request on orderer "<orderer0>" with properties:
330329
| ChainId | Start | End |
@@ -338,7 +337,7 @@ Feature: Bootstrap
338337
Examples: Orderer Options
339338
| ComposeFile | SystemUpWaitTime | ConsensusType | BroadcastWaitTime | orderer0 | orderer1 | orderer2 |Orderer Specific Info|
340339
| docker-compose-next-4.yml | 0 | solo | 2 | orderer0 | orderer0 | orderer0 | |
341-
# | docker-compose-next-4.yml ./environments/orderer-1-kafka-1/docker-compose.yml orderer-3-kafka-1.yml | 5 | kafka | 5 | orderer0 | orderer1 | orderer2 | |
340+
# | docker-compose-next-4.yml ./environments/orderer-1-kafka-1/docker-compose.yml orderer-3-kafka-1.yml | 10 | kafka | 7 | orderer0 | orderer1 | orderer2 | |
342341
# | docker-compose-next-4.yml docker-compose-next-4-couchdb.yml | 10 | solo | 2 | orderer0 | orderer0 | orderer0 | |
343-
# | docker-compose-next-4.yml docker-compose-next-4-couchdb.yml ./environments/orderer-1-kafka-1/docker-compose.yml orderer-3-kafka-1.yml | 10 | kafka | 5 | orderer0 | orderer1 | orderer2 | |
344-
# | docker-compose-next-4.yml ./environments/orderer-1-kafka-3/docker-compose.yml | 5 | kafka | 5 | orderer0 | orderer1 | orderer2 | |
342+
# | docker-compose-next-4.yml docker-compose-next-4-couchdb.yml ./environments/orderer-1-kafka-1/docker-compose.yml orderer-3-kafka-1.yml | 10 | kafka | 7 | orderer0 | orderer1 | orderer2 | |
343+
# | docker-compose-next-4.yml ./environments/orderer-1-kafka-3/docker-compose.yml | 10 | kafka | 7 | orderer0 | orderer0 | orderer0 | |

0 commit comments

Comments
 (0)