Skip to content

Commit 572b679

Browse files
committed
[FAB-4582] Fix gossip proto comments
The gossip proto file has the following section for channel_mac: // channel_MAC is an authentication code that proves // that the peer that sent this message knows // the name of the channel. // The channel name that this message relates to // can only be computed by a peer that has joined // the channel This is a bit misleading since the name of the channel can be computed by dictionary attacks where the name of the channel is guessed, and also by simply knowing the name of the channel beforehand. Change-Id: I7050ac4e814609b0307ec5b573cf7a84d2a80d24 Signed-off-by: Yacov Manevich <[email protected]>
1 parent fcda9a9 commit 572b679

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

protos/gossip/message.proto

-6
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,6 @@ message StateInfo {
126126
// channel_MAC is an authentication code that proves
127127
// that the peer that sent this message knows
128128
// the name of the channel.
129-
// The channel name that this message relates to
130-
// can only be computed by a peer that has joined
131-
// the channel
132129
bytes channel_MAC = 4;
133130
}
134131

@@ -143,9 +140,6 @@ message StateInfoPullRequest {
143140
// channel_MAC is an authentication code that proves
144141
// that the peer that sent this message knows
145142
// the name of the channel.
146-
// The channel name that this message relates to
147-
// can only be computed by a peer that has joined
148-
// the channel
149143
bytes channel_MAC = 1;
150144
}
151145

0 commit comments

Comments
 (0)