Skip to content

Commit 5759ee4

Browse files
committed
[FAB-4005] Add channel name to logs of blocks provider
In case there are problems with fetching blocks it's not clear to which channel it corresponds to: [2017-05-18 07:51:03.230 EDT [blocksProvider] DeliverBlocks -> \ WARN 046ESC[0m Got error &{FORBIDDEN} I added the channel name to some logging invocations Change-Id: If04782e1c847662dfc96c4c137ec54ae5ca01f92 Signed-off-by: Yacov Manevich <[email protected]>
1 parent eaf7f4d commit 5759ee4

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

core/deliverservice/blocksprovider/blocksprovider.go

+8-8
Original file line numberDiff line numberDiff line change
@@ -117,26 +117,26 @@ func (b *blocksProviderImpl) DeliverBlocks() {
117117
for !b.isDone() {
118118
msg, err := b.client.Recv()
119119
if err != nil {
120-
logger.Warningf("Receive error: %s", err.Error())
120+
logger.Warningf("[%s] Receive error: %s", b.chainID, err.Error())
121121
return
122122
}
123123
switch t := msg.Type.(type) {
124124
case *orderer.DeliverResponse_Status:
125125
if t.Status == common.Status_SUCCESS {
126-
logger.Warning("ERROR! Received success for a seek that should never complete")
126+
logger.Warningf("[%s] ERROR! Received success for a seek that should never complete", b.chainID)
127127
return
128128
}
129-
logger.Warning("Got error ", t)
129+
logger.Warningf("[%s] Got error %v", b.chainID, t)
130130
case *orderer.DeliverResponse_Block:
131131
seqNum := t.Block.Header.Number
132132

133133
marshaledBlock, err := proto.Marshal(t.Block)
134134
if err != nil {
135-
logger.Errorf("Error serializing block with sequence number %d, due to %s", seqNum, err)
135+
logger.Errorf("[%s] Error serializing block with sequence number %d, due to %s", b.chainID, seqNum, err)
136136
continue
137137
}
138138
if err := b.mcs.VerifyBlock(gossipcommon.ChainID(b.chainID), seqNum, marshaledBlock); err != nil {
139-
logger.Errorf("Error verifying block with sequnce number %d, due to %s", seqNum, err)
139+
logger.Errorf("[%s] Error verifying block with sequnce number %d, due to %s", b.chainID, seqNum, err)
140140
continue
141141
}
142142

@@ -146,15 +146,15 @@ func (b *blocksProviderImpl) DeliverBlocks() {
146146
// Use payload to create gossip message
147147
gossipMsg := createGossipMsg(b.chainID, payload)
148148

149-
logger.Debugf("Adding payload locally, buffer seqNum = [%d], peers number [%d]", seqNum, numberOfPeers)
149+
logger.Debugf("[%s] Adding payload locally, buffer seqNum = [%d], peers number [%d]", b.chainID, seqNum, numberOfPeers)
150150
// Add payload to local state payloads buffer
151151
b.gossip.AddPayload(b.chainID, payload)
152152

153153
// Gossip messages with other nodes
154-
logger.Debugf("Gossiping block [%d], peers number [%d]", seqNum, numberOfPeers)
154+
logger.Debugf("[%s] Gossiping block [%d], peers number [%d]", b.chainID, seqNum, numberOfPeers)
155155
b.gossip.Gossip(gossipMsg)
156156
default:
157-
logger.Warning("Received unknown: ", t)
157+
logger.Warningf("[%s] Received unknown: ", b.chainID, t)
158158
return
159159
}
160160
}

core/deliverservice/deliveryclient.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ func (d *deliverServiceImpl) StartDeliverForChannel(chainID string, ledgerInfo b
140140
return errors.New(errMsg)
141141
} else {
142142
client := d.newClient(chainID, ledgerInfo)
143-
logger.Debug("This peer will pass blocks from orderer service to other peers")
143+
logger.Debug("This peer will pass blocks from orderer service to other peers for channel", chainID)
144144
d.blockProviders[chainID] = blocksprovider.NewBlocksProvider(chainID, client, d.conf.Gossip, d.conf.CryptoSvc)
145145
go d.blockProviders[chainID].DeliverBlocks()
146146
}

core/deliverservice/requester.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,17 @@ type blocksRequester struct {
3434
func (b *blocksRequester) RequestBlocks(ledgerInfoProvider blocksprovider.LedgerInfo) error {
3535
height, err := ledgerInfoProvider.LedgerHeight()
3636
if err != nil {
37-
logger.Errorf("Can't get legder height from committer [%s]", err)
37+
logger.Errorf("Can't get legder height for channel %s from committer [%s]", b.chainID, err)
3838
return err
3939
}
4040

4141
if height > 0 {
42-
logger.Debugf("Starting deliver with block [%d]", height)
42+
logger.Debugf("Starting deliver with block [%d] for channel %s", height, b.chainID)
4343
if err := b.seekLatestFromCommitter(height); err != nil {
4444
return err
4545
}
4646
} else {
47-
logger.Debug("Starting deliver with olders block")
47+
logger.Debugf("Starting deliver with olders block for channel %s", b.chainID)
4848
if err := b.seekOldest(); err != nil {
4949
return err
5050
}

0 commit comments

Comments
 (0)