[FAB-3953] Re-introduce disabled goroutine leak test

The check was disabled in FAB-3257 and deals with checking
if goroutines that are created during a test are dead after the test ends.
It failed because sometimes the number of goroutines that the test started
with, was higher than the number it ended with.

It should be re-introduced.

I think we should simply instead of checking that the number of goroutines
hasn't changed from the start of the test to the end of the test - check
that it didn't increase, because that proves that a goroutine was created
at the time of the test and hasn't finished.

Change-Id: Id8caabff4723699ede6047d2640f4442948e52e4
Signed-off-by: Yacov Manevich <[email protected]>

Author: yacovm

core/deliverservice/deliveryclient_test.go

@@ -353,19 +353,17 @@ func assertBlockDissemination(expectedSeq uint64, ch chan uint64, t *testing.T)
 }
 
 func ensureNoGoroutineLeak(t *testing.T) func() {
-	//goroutineCountAtStart := runtime.NumGoroutine()
+	goroutineCountAtStart := runtime.NumGoroutine()
 	return func() {
-		// Temporarily disabled, see FAB-3257 for progress
-		/*		start := time.Now()
-				timeLimit := start.Add(goRoutineTestWaitTimeout)
-				for time.Now().Before(timeLimit) {
-					time.Sleep(time.Millisecond * 500)
-					if goroutineCountAtStart == runtime.NumGoroutine() {
-						fmt.Println(getStackTrace())
-						return
-					}
-				}
-				assert.Equal(t, goroutineCountAtStart, runtime.NumGoroutine(), "Some goroutine(s) didn't finish: %s", getStackTrace())*/
+		start := time.Now()
+		timeLimit := start.Add(goRoutineTestWaitTimeout)
+		for time.Now().Before(timeLimit) {
+			time.Sleep(time.Millisecond * 500)
+			if goroutineCountAtStart >= runtime.NumGoroutine() {
+				return
+			}
+		}
+		assert.Fail(t, "Some goroutine(s) didn't finish: %s", getStackTrace())
 	}
 }