[FAB-4428] Check for read error on inspect tx

There was a missing error check when reading a channel create tx from
disk to inspect it, resulting in a confusing error later in the flow.

Change-Id: I3b0189d6c41f59bf524ce2b3fd43111140af75a3
Signed-off-by: Jason Yellick <[email protected]>

Author: Jason Yellick

common/configtx/tool/configtxgen/main.go

@@ -241,6 +241,10 @@ func configGroupAsJSON(group *cb.ConfigGroup) (string, error) {
 func doInspectChannelCreateTx(inspectChannelCreateTx string) error {
 	logger.Info("Inspecting transaction")
 	data, err := ioutil.ReadFile(inspectChannelCreateTx)
+	if err != nil {
+		return fmt.Errorf("could not read channel create tx: %s", err)
+	}
+
 	logger.Info("Parsing transaction")
 	env, err := utils.UnmarshalEnvelope(data)
 	if err != nil {

common/configtx/tool/configtxgen/main_test.go

@@ -72,6 +72,10 @@ func TestMissingConsortiumSection(t *testing.T) {
 	assert.Error(t, doOutputChannelCreateTx(config, "foo", configTxDest), "Missing Consortium section in Application Profile definition")
 }
 
+func TestInspectMissingConfigTx(t *testing.T) {
+	assert.Error(t, doInspectChannelCreateTx("ChannelCreateTxFileWhichDoesn'tReallyExist"), "Missing channel create tx file")
+}
+
 func TestInspectConfigTx(t *testing.T) {
 	configTxDest := tmpDir + string(os.PathSeparator) + "configtx"