[FAB-3257] disable brittle goroutine check in CI test

The goroutine check (checks that goroutines are dead after each test)
sometimes starts with the wrong number of goroutines and has a false-negative
 (i.e, started with 4 goroutines but has only 3 of them in the end of the test)
so it fails the entire unit test run.

I want to temporarily disable the test and investigate.

Change-Id: Ic0b618c6c3437ec8cbe87400e7bd54fc0d74f2ca
Signed-off-by: Yacov Manevich <[email protected]>

Author: yacovm

core/deliverservice/deliveryclient_test.go

@@ -353,17 +353,19 @@ func assertBlockDissemination(expectedSeq uint64, ch chan uint64, t *testing.T)
 }
 
 func ensureNoGoroutineLeak(t *testing.T) func() {
-	goroutineCountAtStart := runtime.NumGoroutine()
+	//goroutineCountAtStart := runtime.NumGoroutine()
 	return func() {
-		start := time.Now()
-		timeLimit := start.Add(goRoutineTestWaitTimeout)
-		for time.Now().Before(timeLimit) {
-			time.Sleep(time.Millisecond * 500)
-			if goroutineCountAtStart == runtime.NumGoroutine() {
-				return
-			}
-		}
-		assert.Equal(t, goroutineCountAtStart, runtime.NumGoroutine(), "Some goroutine(s) didn't finish: %s", getStackTrace())
+		// Temporarily disabled, see FAB-3257 for progress
+		/*		start := time.Now()
+				timeLimit := start.Add(goRoutineTestWaitTimeout)
+				for time.Now().Before(timeLimit) {
+					time.Sleep(time.Millisecond * 500)
+					if goroutineCountAtStart == runtime.NumGoroutine() {
+						fmt.Println(getStackTrace())
+						return
+					}
+				}
+				assert.Equal(t, goroutineCountAtStart, runtime.NumGoroutine(), "Some goroutine(s) didn't finish: %s", getStackTrace())*/
 	}
 }