[FAB-4913] Use the same assert package in tests

This patchset replaces the uses of docker/pkg/testutil/assert with
stretchr/testify/assert, which the majority of test codes are using.

Change-Id: Ic47cdf3e283a9b21cf16763734520f4e1dc3597f
Signed-off-by: Taku Shimosawa <[email protected]>

Author: shimos

bccsp/factory/opts_test.go

@@ -18,7 +18,7 @@ package factory
 import (
 	"testing"
 
-	"github.com/docker/docker/pkg/testutil/assert"
+	"github.com/stretchr/testify/assert"
 )
 
 func TestFactoryOptsFactoryName(t *testing.T) {

core/chaincode/platforms/golang/env_test.go

@@ -20,7 +20,7 @@ import (
 	"os"
 	"testing"
 
-	"github.com/docker/docker/pkg/testutil/assert"
+	"github.com/stretchr/testify/assert"
 )
 
 func Test_splitEnvPath(t *testing.T) {
@@ -30,7 +30,7 @@ func Test_splitEnvPath(t *testing.T) {
 
 func Test_getGoEnv(t *testing.T) {
 	goenv, err := getGoEnv()
-	assert.NilError(t, err)
+	assert.NoError(t, err)
 
 	_, ok := goenv["GOPATH"]
 	assert.Equal(t, ok, true)

core/chaincode/platforms/golang/platform_test.go

@@ -26,10 +26,10 @@ import (
 	"testing"
 	"time"
 
-	"github.com/docker/docker/pkg/testutil/assert"
 	"github.com/hyperledger/fabric/core/config"
 	pb "github.com/hyperledger/fabric/protos/peer"
 	"github.com/spf13/viper"
+	"github.com/stretchr/testify/assert"
 )
 
 func testerr(err error, succ bool) error {
@@ -154,7 +154,7 @@ func Test_DeploymentPayload(t *testing.T) {
 	}
 
 	payload, err := platform.GetDeploymentPayload(spec)
-	assert.NilError(t, err)
+	assert.NoError(t, err)
 
 	t.Logf("payload size: %d", len(payload))
 

gossip/state/metastate_test.go

@@ -19,8 +19,8 @@ package state
 import (
 	"testing"
 
-	"github.com/docker/docker/pkg/testutil/assert"
 	"github.com/hyperledger/fabric/gossip/util"
+	"github.com/stretchr/testify/assert"
 )
 
 func init() {
@@ -44,37 +44,37 @@ func TestNodeMetastateImpl_Bytes(t *testing.T) {
 	metastate := NewNodeMetastate(0)
 	// Encode state into bytes and check there is no errors
 	_, err := metastate.Bytes()
-	assert.NilError(t, err)
+	assert.NoError(t, err)
 }
 
 // Check the deserialization of the meta stats structure
 func TestNodeMetastate_FromBytes(t *testing.T) {
 	metastate := NewNodeMetastate(0)
 	// Serialize into bytes array
 	bytes, err := metastate.Bytes()
-	assert.NilError(t, err)
+	assert.NoError(t, err)
 	if bytes == nil {
 		t.Fatal("Was not able to serialize meta state into byte array.")
 	}
 
 	// Deserialize back and check, that state still have same
 	// height value
 	state, err := FromBytes(bytes)
-	assert.NilError(t, err)
+	assert.NoError(t, err)
 
 	assert.Equal(t, state.Height(), uint64(0))
 
 	// Update state to the new height and serialize it again
 	state.Update(17)
 	bytes, err = state.Bytes()
-	assert.NilError(t, err)
+	assert.NoError(t, err)
 	if bytes == nil {
 		t.Fatal("Was not able to serialize meta state into byte array.")
 	}
 
 	// Restore state from byte array and validate
 	// that stored height is still the same
 	updatedState, err := FromBytes(bytes)
-	assert.NilError(t, err)
+	assert.NoError(t, err)
 	assert.Equal(t, updatedState.Height(), uint64(17))
 }