Skip to content

Commit 9dbf6f7

Browse files
committed
Use logger instead of fmt in SBFT app
Change-Id: I3e84812fbc5c2d3130942cbbbccc6a5d3172d353 Signed-off-by: Gabor Hosszu <[email protected]>
1 parent b777eb8 commit 9dbf6f7

File tree

2 files changed

+15
-13
lines changed

2 files changed

+15
-13
lines changed

orderer/sbft/main/main.go

+15-11
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ package main
1818

1919
import (
2020
"flag"
21-
"fmt"
2221
"net"
2322
_ "net/http/pprof"
2423
"os"
@@ -53,6 +52,13 @@ type flags struct {
5352
init string
5453
}
5554

55+
var logger = logging.MustGetLogger("orderer/main")
56+
57+
// TODO move to_test after integration with common components
58+
func init() {
59+
logging.SetLevel(logging.DEBUG, "")
60+
}
61+
5662
func main() {
5763
var c flags
5864

@@ -70,14 +76,14 @@ func main() {
7076

7177
level, err := logging.LogLevel(c.verbose)
7278
if err != nil {
73-
panic(err)
79+
logger.Panicf("Failed to set loglevel: %s", err)
7480
}
7581
logging.SetLevel(level, "")
7682

7783
if c.init != "" {
7884
err = initInstance(c)
7985
if err != nil {
80-
panic(err)
86+
logger.Panicf("Failed to initialize SBFT instance: %s", err)
8187
}
8288
return
8389
}
@@ -102,26 +108,24 @@ func initInstance(c flags) error {
102108
return err
103109
}
104110

105-
fmt.Println(fmt.Sprintf("initialized new peer: listening at %v GRPC at %v", c.listenAddr, c.grpcAddr))
111+
logger.Infof("Initialized new peer: listening at %v GRPC at %v", c.listenAddr, c.grpcAddr)
106112
return nil
107113
}
108114

109115
func serve(c flags) {
110116
if c.dataDir == "" {
111-
fmt.Fprintln(os.Stderr, "need data directory")
112-
os.Exit(1)
117+
logger.Panic("No data directory was given.")
113118
}
114119

115120
persist := persist.New(c.dataDir)
116121
config, err := sbft.RestoreConfig(persist)
117122
if err != nil {
118-
panic(err)
123+
logger.Panicf("Failed to restore configuration: %s", err)
119124
}
120125

121126
conn, err := connection.New(c.listenAddr, c.certFile, c.keyFile)
122127
if err != nil {
123-
fmt.Fprintln(os.Stderr, "Connection error.")
124-
panic(err)
128+
logger.Panicf("Error when trying to connect: %s", err)
125129
}
126130
s := &consensusStack{
127131
persist: nil,
@@ -134,7 +138,7 @@ func serve(c flags) {
134138
_, ledger := fileledger.New(c.dataDir, genesisBlock)
135139
s.backend, err = backend.NewBackend(config.Peers, conn, ledger, persist)
136140
if err != nil {
137-
panic(err)
141+
logger.Panicf("Failed to create a new backend instance: %s", err)
138142
}
139143

140144
sbft, _ := pb.New(s.backend.GetMyId(), config.Consensus, s.backend)
@@ -143,7 +147,7 @@ func serve(c flags) {
143147
grpcServer := grpc.NewServer()
144148
lis, err := net.Listen("tcp", c.grpcAddr)
145149
if err != nil {
146-
panic(fmt.Sprintf("Failed to listen: %s", err))
150+
logger.Panicf("Failed to listen: %s", err)
147151
}
148152
broadcastab := backend.NewBackendAB(s.backend)
149153
ab.RegisterAtomicBroadcastServer(grpcServer, broadcastab)

orderer/sbft/main/sbft_test.go

-2
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ import (
3232
"google.golang.org/grpc"
3333
)
3434

35-
var logger = logging.MustGetLogger("sbft_test")
36-
3735
const update byte = 0
3836
const sent byte = 1
3937

0 commit comments

Comments
 (0)