Skip to content

Commit a52f2f3

Browse files
committed
Make DeliverServer public
Change-Id: Icff12ae69dc7edfb7f899487188dfbcca82d66a5 Signed-off-by: Gabor Hosszu <[email protected]>
1 parent e6d2c9b commit a52f2f3

File tree

3 files changed

+21
-21
lines changed

3 files changed

+21
-21
lines changed

orderer/solo/deliver.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -21,27 +21,27 @@ import (
2121
"github.com/hyperledger/fabric/orderer/rawledger"
2222
)
2323

24-
type deliverServer struct {
24+
type DeliverServer struct {
2525
rl rawledger.Reader
2626
maxWindow int
2727
}
2828

29-
func newDeliverServer(rl rawledger.Reader, maxWindow int) *deliverServer {
30-
return &deliverServer{
29+
func NewDeliverServer(rl rawledger.Reader, maxWindow int) *DeliverServer {
30+
return &DeliverServer{
3131
rl: rl,
3232
maxWindow: maxWindow,
3333
}
3434
}
3535

36-
func (ds *deliverServer) handleDeliver(srv ab.AtomicBroadcast_DeliverServer) error {
36+
func (ds *DeliverServer) HandleDeliver(srv ab.AtomicBroadcast_DeliverServer) error {
3737
logger.Debugf("Starting new Deliver loop")
3838
d := newDeliverer(ds, srv)
3939
return d.recv()
4040

4141
}
4242

4343
type deliverer struct {
44-
ds *deliverServer
44+
ds *DeliverServer
4545
srv ab.AtomicBroadcast_DeliverServer
4646
cursor rawledger.Iterator
4747
nextBlockNumber uint64
@@ -51,7 +51,7 @@ type deliverer struct {
5151
exitChan chan struct{}
5252
}
5353

54-
func newDeliverer(ds *deliverServer, srv ab.AtomicBroadcast_DeliverServer) *deliverer {
54+
func newDeliverer(ds *DeliverServer, srv ab.AtomicBroadcast_DeliverServer) *deliverer {
5555
d := &deliverer{
5656
ds: ds,
5757
srv: srv,

orderer/solo/deliver_test.go

+12-12
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ func TestOldestSeek(t *testing.T) {
6565

6666
m := newMockD()
6767
defer close(m.recvChan)
68-
ds := newDeliverServer(rl, MagicLargestWindow)
68+
ds := NewDeliverServer(rl, MagicLargestWindow)
6969

70-
go ds.handleDeliver(m)
70+
go ds.HandleDeliver(m)
7171

7272
m.recvChan <- &ab.DeliverUpdate{Type: &ab.DeliverUpdate_Seek{Seek: &ab.SeekInfo{WindowSize: uint64(MagicLargestWindow), Start: ab.SeekInfo_OLDEST}}}
7373

@@ -97,9 +97,9 @@ func TestNewestSeek(t *testing.T) {
9797

9898
m := newMockD()
9999
defer close(m.recvChan)
100-
ds := newDeliverServer(rl, MagicLargestWindow)
100+
ds := NewDeliverServer(rl, MagicLargestWindow)
101101

102-
go ds.handleDeliver(m)
102+
go ds.HandleDeliver(m)
103103

104104
m.recvChan <- &ab.DeliverUpdate{Type: &ab.DeliverUpdate_Seek{Seek: &ab.SeekInfo{WindowSize: uint64(MagicLargestWindow), Start: ab.SeekInfo_NEWEST}}}
105105

@@ -125,9 +125,9 @@ func TestSpecificSeek(t *testing.T) {
125125
}
126126

127127
m := newMockD()
128-
ds := newDeliverServer(rl, MagicLargestWindow)
128+
ds := NewDeliverServer(rl, MagicLargestWindow)
129129

130-
go ds.handleDeliver(m)
130+
go ds.HandleDeliver(m)
131131

132132
m.recvChan <- &ab.DeliverUpdate{Type: &ab.DeliverUpdate_Seek{Seek: &ab.SeekInfo{WindowSize: uint64(MagicLargestWindow), Start: ab.SeekInfo_SPECIFIED, SpecifiedNumber: uint64(ledgerSize - 1)}}}
133133

@@ -154,9 +154,9 @@ func TestBadSeek(t *testing.T) {
154154

155155
m := newMockD()
156156
defer close(m.recvChan)
157-
ds := newDeliverServer(rl, MagicLargestWindow)
157+
ds := NewDeliverServer(rl, MagicLargestWindow)
158158

159-
go ds.handleDeliver(m)
159+
go ds.HandleDeliver(m)
160160

161161
m.recvChan <- &ab.DeliverUpdate{Type: &ab.DeliverUpdate_Seek{Seek: &ab.SeekInfo{WindowSize: uint64(MagicLargestWindow), Start: ab.SeekInfo_SPECIFIED, SpecifiedNumber: uint64(ledgerSize - 1)}}}
162162

@@ -187,9 +187,9 @@ func TestBadWindow(t *testing.T) {
187187

188188
m := newMockD()
189189
defer close(m.recvChan)
190-
ds := newDeliverServer(rl, MagicLargestWindow)
190+
ds := NewDeliverServer(rl, MagicLargestWindow)
191191

192-
go ds.handleDeliver(m)
192+
go ds.HandleDeliver(m)
193193

194194
m.recvChan <- &ab.DeliverUpdate{Type: &ab.DeliverUpdate_Seek{Seek: &ab.SeekInfo{WindowSize: uint64(MagicLargestWindow) * 2, Start: ab.SeekInfo_OLDEST}}}
195195

@@ -213,9 +213,9 @@ func TestAck(t *testing.T) {
213213

214214
m := newMockD()
215215
defer close(m.recvChan)
216-
ds := newDeliverServer(rl, MagicLargestWindow)
216+
ds := NewDeliverServer(rl, MagicLargestWindow)
217217

218-
go ds.handleDeliver(m)
218+
go ds.HandleDeliver(m)
219219

220220
m.recvChan <- &ab.DeliverUpdate{Type: &ab.DeliverUpdate_Seek{Seek: &ab.SeekInfo{WindowSize: windowSize, Start: ab.SeekInfo_OLDEST}}}
221221

orderer/solo/solo.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,15 @@ func init() {
3636

3737
type server struct {
3838
bs *broadcastServer
39-
ds *deliverServer
39+
ds *DeliverServer
4040
}
4141

4242
// New creates a ab.AtomicBroadcastServer based on the solo orderer implementation
4343
func New(queueSize, batchSize, maxWindowSize int, batchTimeout time.Duration, rl rawledger.ReadWriter, grpcServer *grpc.Server, filters *broadcastfilter.RuleSet, configManager configtx.Manager) ab.AtomicBroadcastServer {
4444
logger.Infof("Starting solo with queueSize=%d, batchSize=%d batchTimeout=%v and ledger=%T", queueSize, batchSize, batchTimeout, rl)
4545
s := &server{
4646
bs: newBroadcastServer(queueSize, batchSize, batchTimeout, rl, filters, configManager),
47-
ds: newDeliverServer(rl, maxWindowSize),
47+
ds: NewDeliverServer(rl, maxWindowSize),
4848
}
4949
ab.RegisterAtomicBroadcastServer(grpcServer, s)
5050
return s
@@ -58,5 +58,5 @@ func (s *server) Broadcast(srv ab.AtomicBroadcast_BroadcastServer) error {
5858
// Deliver sends a stream of blocks to a client after ordering
5959
func (s *server) Deliver(srv ab.AtomicBroadcast_DeliverServer) error {
6060
logger.Debugf("Starting new Deliver loop")
61-
return s.ds.handleDeliver(srv)
61+
return s.ds.HandleDeliver(srv)
6262
}

0 commit comments

Comments
 (0)