Skip to content

Commit bc28d27

Browse files
committed
[FAB-3207] fix JoinChan fails at event publish failing
If the event publishing fails, the join channel also fails. This shouldn't be so, because an event publishing might fail because a subscriber is reading too slow from the stream. Change-Id: I82202d478a12b555f6c7f63a52580c607ca3b15d Signed-off-by: Yacov Manevich <[email protected]>
1 parent 7f336b9 commit bc28d27

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

core/scc/cscc/configure.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,7 @@ func joinChain(blockBytes []byte) pb.Response {
122122
peer.InitChain(chainID)
123123

124124
if err := producer.SendProducerBlockEvent(block); err != nil {
125-
msg := fmt.Sprintf("Error sending block event %s", err)
126-
return shim.Error(msg)
125+
cnflogger.Errorf("Error sending block event %s", err)
127126
}
128127

129128
return shim.Success(nil)
@@ -143,6 +142,7 @@ func updateConfigBlock(blockBytes []byte) pb.Response {
143142
}
144143

145144
if err := peer.SetCurrConfigBlock(block, chainID); err != nil {
145+
146146
return shim.Error(err.Error())
147147
}
148148

0 commit comments

Comments
 (0)