[FAB-3636] Check the error, associating id to cert

Currently in the communication gossip module while creating a new
instance in the method NewCommInstanceWithServer there is an associating
between peer pkiid and cert, however no error check has been made, hence
ignoring potential problem.

Same problem also exists in gossip_service.go.

This commit adds error check, reporting to the log and panic, since this
is an indication of peer bad condition.

Change-Id: Id1da501581b5a9e96b08343b80133286b3ade0d0
Signed-off-by: Artem Barger <[email protected]>

Author: C0rWin

gossip/comm/comm_impl.go

@@ -99,7 +99,9 @@ func NewCommInstanceWithServer(port int, idMapper identity.Mapper, peerIdentity
 		subscriptions:  make([]chan proto.ReceivedMessage, 0),
 	}
 	commInst.connStore = newConnStore(commInst, commInst.logger)
-	commInst.idMapper.Put(idMapper.GetPKIidOfCert(peerIdentity), peerIdentity)
+	if err := commInst.idMapper.Put(idMapper.GetPKIidOfCert(peerIdentity), peerIdentity); err != nil {
+		commInst.logger.Panic("Failed associating self PKIID to cert:", err)
+	}
 
 	if port > 0 {
 		commInst.stopWG.Add(1)

gossip/service/gossip_service.go

@@ -138,7 +138,9 @@ func InitGossipServiceCustomDeliveryFactory(peerIdentity []byte, endpoint string
 		logger.Info("Initialize gossip with endpoint", endpoint, "and bootstrap set", bootPeers)
 
 		idMapper := identity.NewIdentityMapper(mcs)
-		idMapper.Put(mcs.GetPKIidOfCert(peerIdentity), peerIdentity)
+		if err := idMapper.Put(mcs.GetPKIidOfCert(peerIdentity), peerIdentity); err != nil {
+			logger.Panic("Failed associating self PKIID to cert:", err)
+		}
 
 		gossip := integration.NewGossipComponent(peerIdentity, endpoint, s, secAdv,
 			mcs, idMapper, secureDialOpts, bootPeers...)