Gossip discovery: validate dead members bug fix

yacovm · yacovm · commit c9e9cc15c2c7 · 2017-03-03T10:45:31.000+02:00
When receiving a membership request, the validation
of dead peers messages was done on the top level message instead

Change-Id: I1596358993404af6b01b813e5cbf053c48ba8d31
Signed-off-by: Yacov Manevich &lt;yacovm@il.ibm.com&gt;
diff --git a/gossip/discovery/discovery_impl.go b/gossip/discovery/discovery_impl.go
@@ -337,7 +337,7 @@ func (d *gossipDiscoveryImpl) handleMsgFromComm(m *proto.SignedGossipMessage) {
 				d.logger.Warning("Membership response contains an invalid message from an offline peer", err)
 				return
 			}
-			if !d.crypt.ValidateAliveMsg(m) {
+			if !d.crypt.ValidateAliveMsg(dm) {
 				d.logger.Warningf("Alive message isn't authentic, someone spoofed %s's identity", dm.GetAliveMsg().Membership)
 				continue
 			}

Original file line number	Diff line number	Diff line change
`@@ -337,7 +337,7 @@ func (d gossipDiscoveryImpl) handleMsgFromComm(m proto.SignedGossipMessage) {`
`337`	`337`	`d.logger.Warning("Membership response contains an invalid message from an offline peer", err)`
`338`	`338`	`return`
`339`	`339`	`}`
`340`		`- if !d.crypt.ValidateAliveMsg(m) {`
	`340`	`+ if !d.crypt.ValidateAliveMsg(dm) {`
`341`	`341`	`d.logger.Warningf("Alive message isn't authentic, someone spoofed %s's identity", dm.GetAliveMsg().Membership)`
`342`	`342`	`continue`
`343`	`343`	`}`