Remove RYW (Read-Your-Writes) support

https://jira.hyperledger.org/browse/FAB-1187

Change-Id: I880fb399e4577135c50fba4c781b28902da33e84
Signed-off-by: manish <[email protected]>

Author: manish-sethi

core/ledger/kvledger/txmgmt/txmgr/commontests/txmgr_test.go

@@ -48,10 +48,6 @@ func testTxSimulatorWithNoExistingData(t *testing.T, env testEnv) {
 	s.SetState("ns2", "key3", []byte("value3"))
 	s.SetState("ns2", "key4", []byte("value4"))
 
-	value, _ = s.GetState("ns2", "key3")
-	testutil.AssertEquals(t, value, []byte("value3"))
-
-	s.DeleteState("ns2", "key3")
 	value, _ = s.GetState("ns2", "key3")
 	testutil.AssertNil(t, value)
 }
@@ -86,7 +82,7 @@ func testTxSimulatorWithExistingData(t *testing.T, env testEnv) {
 	s2.SetState("ns1", "key1", []byte("value1_1"))
 	s2.DeleteState("ns2", "key3")
 	value, _ = s2.GetState("ns1", "key1")
-	testutil.AssertEquals(t, value, []byte("value1_1"))
+	testutil.AssertEquals(t, value, []byte("value1"))
 	s2.Done()
 	// validate and commit RWset for tx2
 	txRWSet2, _ := s2.GetTxSimulationResults()

core/ledger/kvledger/txmgmt/txmgr/lockbasedtxmgr/lockbased_tx_simulator.go

@@ -39,12 +39,6 @@ func newLockBasedTxSimulator(txmgr *LockBasedTxMgr) *lockBasedTxSimulator {
 
 // GetState implements method in interface `ledger.TxSimulator`
 func (s *lockBasedTxSimulator) GetState(ns string, key string) ([]byte, error) {
-	// Remove RYWs when table APIs are removed
-	logger.Debugf("s.rwset=%s", s.rwset)
-	value, ok := s.rwset.GetFromWriteSet(ns, key)
-	if ok {
-		return value, nil
-	}
 	return s.helper.getState(ns, key)
 }