Skip to content

Commit f5a4dae

Browse files
FAB-3882 Add proposal process to CONTRIBUTING.rst
addressed review feedback Change-Id: Iaf3a2675241728cb7c08b48afa5acaba35aff817 Signed-off-by: Christopher Ferris <[email protected]>
1 parent 689b8f4 commit f5a4dae

File tree

1 file changed

+26
-7
lines changed

1 file changed

+26
-7
lines changed

docs/source/CONTRIBUTING.rst

+26-7
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,32 @@ assignment if you cannot finish in a reasonable time, or add a comment
8181
saying that you are still actively working the issue if you need a
8282
little more time.
8383

84+
Making Feature/Enhancement Proposals
85+
------------------------------------
86+
87+
Review
88+
`JIRA <https://jira.hyperledger.org/secure/Dashboard.jspa?selectPageId=10104>`__.
89+
to be sure that there isn't already an open (or recently closed) proposal for the
90+
same function. If there isn't, to make a proposal we recommend that you open a
91+
JIRA Epic, Story or Improvement, whichever seems to best fit the circumstance and
92+
link or inline a "one pager" of the proposal that states what the feature would
93+
do and, if possible, how it might be implemented. It would help also to make a
94+
case for why the feature should be added, such as identifying specific use
95+
case(s) for which the feature is needed and a case for what the benefit would be
96+
should the feature be implemented. Once the JIRA issue is created, and the
97+
"one pager" either attached, inlined in the description field, or a link to a
98+
publicly accessible document is added to the description, send an introductory
99+
email to the [email protected] mailing list linking the
100+
JIRA issue, and soliciting feedback.
101+
102+
Discussion of the proposed feature should be conducted in the JIRA issue itself,
103+
so that we have a consistent pattern within our community as to where to find
104+
design discussion.
105+
106+
Getting the support of three or more of the Fabric maintainers for the new
107+
feature will greatly enhance the probability that the feature's related CRs
108+
will be merged.
109+
84110
Working with a local clone and Gerrit
85111
-------------------------------------
86112

@@ -182,13 +208,6 @@ comments such that it gets to a point that it requires a rebase. It only
182208
further delays getting it merged and adds more work for you - to
183209
remediate the merge conflicts.
184210

185-
Coding guidelines
186-
-----------------
187-
188-
Be sure to check out the language-specific :doc:`style
189-
guides <Style-guides/go-style>` before making any changes. This
190-
will ensure a smoother review.
191-
192211
Communication
193212
--------------
194213

0 commit comments

Comments
 (0)