Skip to content

Commit fc268da

Browse files
committed
[FAB-3288] Sync configtx.yaml with Compose configs
The default value in configtx.yaml for "Absolute Max Bytes", the size batches that the ordering service outputs, breaks the Docker Compose configuration files in "bddtests/environments". This changeset brings all configurations in sync. Change-Id: Ib1eac16331cc311335b1479a048b39983d350aba Signed-off-by: Kostas Christidis <[email protected]>
1 parent f4a7631 commit fc268da

File tree

3 files changed

+26
-14
lines changed

3 files changed

+26
-14
lines changed

bddtests/environments/orderer-1-kafka-1/docker-compose.yml

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ services:
2121
image: hyperledger/fabric-kafka
2222
environment:
2323
KAFKA_BROKER_ID: 0
24+
KAFKA_MESSAGE_MAX_BYTES: 103809024
25+
KAFKA_REPLICA_FETCH_MAX_BYTES: 103809024
2426
KAFKA_UNCLEAN_LEADER_ELECTION_ENABLE: "false"
2527
KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181
2628
depends_on:

bddtests/environments/orderer-1-kafka-3/docker-compose.yml

+6
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ services:
2424
environment:
2525
KAFKA_BROKER_ID: 0
2626
KAFKA_DEFAULT_REPLICATION_FACTOR: 3
27+
KAFKA_MESSAGE_MAX_BYTES: 103809024
28+
KAFKA_REPLICA_FETCH_MAX_BYTES: 103809024
2729
KAFKA_UNCLEAN_LEADER_ELECTION_ENABLE: "false"
2830
KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181
2931
depends_on:
@@ -34,6 +36,8 @@ services:
3436
environment:
3537
KAFKA_BROKER_ID: 1
3638
KAFKA_DEFAULT_REPLICATION_FACTOR: 3
39+
KAFKA_MESSAGE_MAX_BYTES: 103809024
40+
KAFKA_REPLICA_FETCH_MAX_BYTES: 103809024
3741
KAFKA_UNCLEAN_LEADER_ELECTION_ENABLE: "false"
3842
KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181
3943
depends_on:
@@ -44,6 +48,8 @@ services:
4448
environment:
4549
KAFKA_BROKER_ID: 2
4650
KAFKA_DEFAULT_REPLICATION_FACTOR: 3
51+
KAFKA_MESSAGE_MAX_BYTES: 103809024
52+
KAFKA_REPLICA_FETCH_MAX_BYTES: 103809024
4753
KAFKA_UNCLEAN_LEADER_ELECTION_ENABLE: "false"
4854
KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181
4955
depends_on:

sampleconfig/configtx.yaml

+18-14
Original file line numberDiff line numberDiff line change
@@ -92,30 +92,32 @@ Organizations:
9292
# MSPDir is the filesystem path which contains the MSP configuration.
9393
MSPDir: msp
9494

95-
# AdminPrincipal dictates the type of principal used for an organization's Admins policy
96-
# Today, only the values of Role.ADMIN ad Role.MEMBER are accepted, which indicates a principal
97-
# of role type ADMIN and role type MEMBER respectively
95+
# AdminPrincipal dictates the type of principal used for an
96+
# organization's Admins policy. Today, only the values of Role.ADMIN and
97+
# Role.MEMBER are accepted, which indicates a principal of role type
98+
# ADMIN and role type MEMBER respectively.
9899
AdminPrincipal: Role.ADMIN
99100

100101
# BCCSP: Select which crypto implementation or library to use for the
101102
# blockchain crypto service provider.
102103
BCCSP:
103104
Default: SW
104105
SW:
105-
# TODO: The default Hash and Security level needs refactoring to be
106-
# fully configurable. Changing these defaults requires coordination
107-
# SHA2 is hardcoded in several places, not only BCCSP
106+
# TODO: The default Hash and Security level needs refactoring to
107+
# be fully configurable. Changing these defaults requires
108+
# coordination SHA2 is hardcoded in several places, not only
109+
# BCCSP.
108110
Hash: SHA2
109111
Security: 256
110-
# Location of key store. If this is unset, a location will
111-
# be chosen using: 'MSPDir'/keystore
112+
# Location of key store. If this is unset, a location will be
113+
# chosen using: 'MSPDir'/keystore
112114
FileKeyStore:
113115
KeyStore:
114116

115117
AnchorPeers:
116-
# AnchorPeers defines the location of peers which can be used
117-
# for cross org gossip communication. Note, this value is only
118-
# encoded in the genesis block in the Application section context.
118+
# AnchorPeers defines the location of peers which can be used for
119+
# cross-org gossip communication. Note, this value is only encoded
120+
# in the genesis block in the Application section context.
119121
- Host: 127.0.0.1
120122
Port: 7051
121123

@@ -147,7 +149,9 @@ Orderer: &OrdererDefaults
147149
MaxMessageCount: 10
148150

149151
# Absolute Max Bytes: The absolute maximum number of bytes allowed for
150-
# the serialized messages in a batch.
152+
# the serialized messages in a batch. If the "kafka" OrdererType is
153+
# selected, set 'message.max.bytes' and 'replica.fetch.max.bytes' on the
154+
# Kafka brokers to a value that is equal to or larger than this one.
151155
AbsoluteMaxBytes: 99 MB
152156

153157
# Preferred Max Bytes: The preferred maximum number of bytes allowed for
@@ -156,8 +160,8 @@ Orderer: &OrdererDefaults
156160
# bytes.
157161
PreferredMaxBytes: 512 KB
158162

159-
# Max Channels is the maximum number of channels to allow on the ordering network
160-
# When set to 0, this implies no maximum number of channels
163+
# Max Channels is the maximum number of channels to allow on the ordering
164+
# network. When set to 0, this implies no maximum number of channels.
161165
MaxChannels: 0
162166

163167
Kafka:

0 commit comments

Comments
 (0)