From 2fe6ad70c75b56384bd495a1d61c71f17ba06b1d Mon Sep 17 00:00:00 2001 From: Roey Ben Chaim Date: Mon, 29 Jul 2024 02:35:08 -0700 Subject: [PATCH] closing handles (#1424) --- .../presidio_analyzer/analyzer_engine_provider.py | 12 ++++++++---- .../nlp_engine/nlp_engine_provider.py | 3 ++- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/presidio-analyzer/presidio_analyzer/analyzer_engine_provider.py b/presidio-analyzer/presidio_analyzer/analyzer_engine_provider.py index fc86c36b6..06ca66ec1 100644 --- a/presidio-analyzer/presidio_analyzer/analyzer_engine_provider.py +++ b/presidio-analyzer/presidio_analyzer/analyzer_engine_provider.py @@ -40,7 +40,8 @@ def get_configuration( if not conf_file: default_conf_file = self._get_full_conf_path() - configuration = yaml.safe_load(open(default_conf_file)) + with open(default_conf_file) as file: + configuration = yaml.safe_load(file) logger.info( f"Analyzer Engine configuration file " f"not provided. Using {default_conf_file}." @@ -48,16 +49,19 @@ def get_configuration( else: try: logger.info(f"Reading analyzer configuration from {conf_file}") - configuration = yaml.safe_load(open(conf_file)) + with open(conf_file) as file: + configuration = yaml.safe_load(file) except OSError: logger.warning( f"configuration file {conf_file} not found. " f"Using default config." ) - configuration = yaml.safe_load(open(self._get_full_conf_path())) + with open(self._get_full_conf_path()) as file: + configuration = yaml.safe_load(file) except Exception: print(f"Failed to parse file {conf_file}, resorting to default") - configuration = yaml.safe_load(open(self._get_full_conf_path())) + with open(self._get_full_conf_path()) as file: + configuration = yaml.safe_load(file) return configuration diff --git a/presidio-analyzer/presidio_analyzer/nlp_engine/nlp_engine_provider.py b/presidio-analyzer/presidio_analyzer/nlp_engine/nlp_engine_provider.py index 65d6d8c1c..767b3908d 100644 --- a/presidio-analyzer/presidio_analyzer/nlp_engine/nlp_engine_provider.py +++ b/presidio-analyzer/presidio_analyzer/nlp_engine/nlp_engine_provider.py @@ -121,7 +121,8 @@ def _read_nlp_conf(conf_file: Union[Path, str]) -> dict: ) else: - nlp_configuration = yaml.safe_load(open(conf_file)) + with open(conf_file) as file: + nlp_configuration = yaml.safe_load(file) if "ner_model_configuration" not in nlp_configuration: logger.warning(