From 30ed452eddacace2c3270dce9645b8f1f453ae4b Mon Sep 17 00:00:00 2001 From: Sandy Zhang Date: Tue, 26 Nov 2024 16:09:23 -0800 Subject: [PATCH] Breaking Change: Remove deprecated Arena::GetArena. This has been marked ABSL_DEPRECATED as of v4.23.x and should be replaced with a direct call to value->GetArena for performance reasons. See https://engdoc.corp.google.com/eng/doc/devguide/proto/news/2024-10-02.md#arenagetarena PiperOrigin-RevId: 700488709 --- src/google/protobuf/arena.h | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/google/protobuf/arena.h b/src/google/protobuf/arena.h index 6e9a0f08414c3..5491917f11f4c 100644 --- a/src/google/protobuf/arena.h +++ b/src/google/protobuf/arena.h @@ -345,18 +345,6 @@ class PROTOBUF_EXPORT PROTOBUF_ALIGNAS(8) Arena final { impl_.AddCleanup(object, destruct); } - // Retrieves the arena associated with |value| if |value| is an arena-capable - // message, or nullptr otherwise. If possible, the call resolves at compile - // time. Note that we can often devirtualize calls to `value->GetArena()` so - // usually calling this method is unnecessary. - // TODO: remove this function. - template - ABSL_DEPRECATED( - "This will be removed in a future release. Call value->GetArena() " - "instead.") - PROTOBUF_ALWAYS_INLINE static Arena* GetArena(T* value) { - return GetArenaInternal(value); - } template class InternalHelper {