Skip to content

Commit 057d646

Browse files
jshacpu
authored andcommitted
fix build: pin a specific nightly
1 parent fbcbda8 commit 057d646

File tree

2 files changed

+24
-2
lines changed

2 files changed

+24
-2
lines changed

.github/workflows/test.yaml

+17-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
# Note: This test file temporarily pins nightly-2023-11-01 instead of the latest nightly,
2+
# because the requirements for an unstable feature changed recently, which causes this
3+
# error on latest nightly:
4+
#
5+
# error[E0658]: use of unstable library feature 'core_io_borrowed_buf'
6+
#
17
name: rustls-ffi
28

39
permissions:
@@ -78,6 +84,8 @@ jobs:
7884
persist-credentials: false
7985
- name: Install nightly rust toolchain
8086
uses: dtolnay/rust-toolchain@nightly
87+
with:
88+
toolchain: nightly-2023-11-01
8189
- name: Configure CMake
8290
run: cmake -S . -B build
8391
- name: Build, debug configuration
@@ -95,6 +103,8 @@ jobs:
95103
persist-credentials: false
96104
- name: Install nightly rust toolchain
97105
uses: dtolnay/rust-toolchain@nightly
106+
with:
107+
toolchain: nightly-2023-11-01
98108
- name: Configure CMake
99109
run: cmake -S . -B build
100110
- name: Build, release configuration
@@ -109,8 +119,10 @@ jobs:
109119
- uses: actions/checkout@v4
110120
with:
111121
persist-credentials: false
112-
- name: Install nightly rust toolchain
122+
- name: Install stable rust toolchain
113123
uses: dtolnay/rust-toolchain@nightly
124+
with:
125+
toolchain: nightly-2023-11-01
114126
- name: Install cbindgen
115127
# Pin the installed version of cbindgen so that local usage can be
116128
# reliably matched to CI. There can be non-semantic differences in
@@ -133,6 +145,8 @@ jobs:
133145

134146
- name: Install rust toolchain
135147
uses: dtolnay/rust-toolchain@nightly
148+
with:
149+
toolchain: nightly-2023-11-01
136150

137151
- name: cargo doc (all features)
138152
run: cargo doc --all-features --no-deps --workspace
@@ -150,6 +164,8 @@ jobs:
150164

151165
- name: Install rust toolchain
152166
uses: dtolnay/rust-toolchain@nightly
167+
with:
168+
toolchain: nightly-2023-11-01
153169

154170
- name: Build client/server binaries
155171
run: make target/client target/server

README.md

+7-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,13 @@ to provide the cryptographic primitives.
2020
# Build
2121

2222
You'll need to [install the Rust toolchain](https://rustup.rs/) (version 1.61
23-
or above) and a C compiler (`gcc` and `clang` should both work). To build in optimized mode:
23+
or above) and a C compiler (`gcc` and `clang` should both work).
24+
25+
If you're using the Rust nightly toolchain, note that toolchains after about
26+
2023-11-01 will error due to [the core_io_borrowed_buf feature](https://github.com/rust-lang/rust/issues/117693).
27+
Use a stable toolchain for now, as we work on updating compatibility.
28+
29+
To build in optimized mode:
2430

2531
make
2632

0 commit comments

Comments
 (0)