cipher: lift rustls_certificate_get_der out of impl block

For some reason, since adding a lifetime to the `rustls_certificate`
type, the `rustls_certificate_get_der` fn inside the `impl
rustls_certificate` block isn't being picked up by cbindgen, removing it
from the `rustls.h` generated header file.

This commit lifts the fn out of the `impl` block into a free-standing
function, now its properly included in `rustls.h` again.

Author: cpu

src/cipher.rs

@@ -44,27 +44,25 @@ impl<'a> Castable for rustls_certificate<'a> {
     type RustType = CertificateDer<'a>;
 }
 
-impl<'a> rustls_certificate<'a> {
-    /// Get the DER data of the certificate itself.
-    /// The data is owned by the certificate and has the same lifetime.
-    #[no_mangle]
-    pub extern "C" fn rustls_certificate_get_der(
-        cert: *const rustls_certificate,
-        out_der_data: *mut *const u8,
-        out_der_len: *mut size_t,
-    ) -> rustls_result {
-        ffi_panic_boundary! {
-            let cert = try_ref_from_ptr!(cert);
-            if out_der_data.is_null() || out_der_len.is_null() {
-                return NullParameter
-            }
-            let der = cert.as_ref();
-            unsafe {
-                *out_der_data = der.as_ptr();
-                *out_der_len = der.len();
-            }
-            rustls_result::Ok
+/// Get the DER data of the certificate itself.
+/// The data is owned by the certificate and has the same lifetime.
+#[no_mangle]
+pub extern "C" fn rustls_certificate_get_der(
+    cert: *const rustls_certificate,
+    out_der_data: *mut *const u8,
+    out_der_len: *mut size_t,
+) -> rustls_result {
+    ffi_panic_boundary! {
+        let cert = try_ref_from_ptr!(cert);
+        if out_der_data.is_null() || out_der_len.is_null() {
+            return NullParameter
         }
+        let der = cert.as_ref();
+        unsafe {
+            *out_der_data = der.as_ptr();
+            *out_der_len = der.len();
+        }
+        rustls_result::Ok
     }
 }
 

src/rustls.h

@@ -836,6 +836,14 @@ rustls_result rustls_accepted_into_connection(struct rustls_accepted *accepted,
  */
 void rustls_accepted_free(struct rustls_accepted *accepted);
 
+/**
+ * Get the DER data of the certificate itself.
+ * The data is owned by the certificate and has the same lifetime.
+ */
+rustls_result rustls_certificate_get_der(const struct rustls_certificate *cert,
+                                         const uint8_t **out_der_data,
+                                         size_t *out_der_len);
+
 /**
  * Return a 16-bit unsigned integer corresponding to this cipher suite's assignment from
  * <https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-4>.