Add support for WASM targets running in a custom runtime (#83)

* Add support for injecting unix millisecond time function for non-JS WASM targets

* Cleanup dependencies in WASM targets

* Rename feature for better conveying the intention

* Run cargo fmt and add getrandom as dev dependency

* Revert feature conditional cfg in tests

* Make sure wasm-pack only runs features that are compatible with wasm-bindgen

---------

Co-authored-by: AndyTitu <[email protected]>

Author: hculea

.github/workflows/zxcvbn.yml

@@ -96,4 +96,6 @@ jobs:
         run: cargo build --target wasm32-unknown-unknown --tests --benches
 
       - name: Run tests (wasm, all features)
-        run: wasm-pack test --node --all-features
+        env:
+          ALL_WASM_BINDGEN_FEATURES: "default,ser,builder"
+        run: wasm-pack test --node --features $ALL_WASM_BINDGEN_FEATURES

Cargo.toml

@@ -22,7 +22,7 @@ regex = "1"
 time = { version = "0.3" }
 
 [target.'cfg(target_arch = "wasm32")'.dependencies]
-getrandom = { version = "0.2", features = ["js"] }
+chrono = "0.4.38"
 wasm-bindgen = "0.2"
 web-sys = { version = "0.3", features = ["Performance"] }
 
@@ -41,12 +41,14 @@ serde_json = "1"
 
 [target.'cfg(target_arch = "wasm32")'.dev-dependencies]
 criterion = { version = "0.5", default-features = false }
+getrandom = { version = "0.2", features = ["js"] }
 wasm-bindgen-test = "0.3"
 
 [features]
 default = ["builder"]
 ser = ["serde"]
 builder = ["derive_builder"]
+custom_wasm_env = []
 
 [profile.test]
 opt-level = 2

src/lib.rs

@@ -1,7 +1,6 @@
 #![doc = include_str!("../README.md")]
 #![recursion_limit = "128"]
 #![warn(missing_docs)]
-#![forbid(unsafe_code)]
 
 #[macro_use]
 #[cfg(feature = "builder")]
@@ -18,7 +17,7 @@ extern crate quickcheck;
 
 pub use scoring::Score;
 use time_estimates::CrackTimes;
-#[cfg(target_arch = "wasm32")]
+#[cfg(all(target_arch = "wasm32", not(feature = "custom_wasm_env")))]
 use wasm_bindgen::prelude::wasm_bindgen;
 
 pub use crate::matching::Match;
@@ -42,7 +41,7 @@ where
     (result, calc_time)
 }
 
-#[cfg(target_arch = "wasm32")]
+#[cfg(all(target_arch = "wasm32", not(feature = "custom_wasm_env")))]
 #[allow(non_upper_case_globals)]
 fn time_scoped<F, R>(f: F) -> (R, Duration)
 where
@@ -61,6 +60,23 @@ where
     (result, calc_time)
 }
 
+#[cfg(all(target_arch = "wasm32", feature = "custom_wasm_env"))]
+fn time_scoped<F, R>(f: F) -> (R, Duration)
+where
+    F: FnOnce() -> R,
+{
+    #[link(wasm_import_module = "zxcvbn")]
+    extern "C" {
+        fn unix_time_milliseconds_imported() -> u64;
+    }
+    let start_time = unsafe { unix_time_milliseconds_imported() };
+    let result = f();
+    let end_time = unsafe { unix_time_milliseconds_imported() };
+
+    let duration = std::time::Duration::from_millis(end_time - start_time);
+    (result, duration)
+}
+
 /// Contains the results of an entropy calculation
 #[derive(Debug, Clone)]
 #[cfg_attr(feature = "ser", derive(serde::Serialize))]

src/scoring.rs

@@ -77,14 +77,31 @@ lazy_static! {
     pub(crate) static ref REFERENCE_YEAR: i32 = time::OffsetDateTime::now_utc().year();
 }
 
-#[cfg(target_arch = "wasm32")]
+#[cfg(all(target_arch = "wasm32", not(feature = "custom_wasm_env")))]
 lazy_static! {
     pub(crate) static ref REFERENCE_YEAR: i32 = web_sys::js_sys::Date::new_0()
         .get_full_year()
         .try_into()
         .unwrap();
 }
 
+#[cfg(all(target_arch = "wasm32", feature = "custom_wasm_env"))]
+lazy_static! {
+    pub(crate) static ref REFERENCE_YEAR: i32 = {
+        #[link(wasm_import_module = "zxcvbn")]
+        extern "C" {
+            fn unix_time_milliseconds_imported() -> u64;
+        }
+        let unix_millis = unsafe { unix_time_milliseconds_imported() };
+
+        use chrono::Datelike;
+        chrono::DateTime::<chrono::Utc>::from(
+            std::time::SystemTime::UNIX_EPOCH + std::time::Duration::from_millis(unix_millis),
+        )
+        .year()
+    };
+}
+
 const MIN_YEAR_SPACE: i32 = 20;
 const BRUTEFORCE_CARDINALITY: u64 = 10;
 const MIN_GUESSES_BEFORE_GROWING_SEQUENCE: u64 = 10_000;