From 1cb864821dd92899f3f3cff4bd65d9b0e07f7854 Mon Sep 17 00:00:00 2001 From: Myungchul Keum <8174871+dofuuz@users.noreply.github.com> Date: Wed, 19 Feb 2025 10:06:37 +0900 Subject: [PATCH 1/2] CI upload artifact --- .github/workflows/action.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/action.yml b/.github/workflows/action.yml index 9a5bd50089..9ca5fbab9c 100644 --- a/.github/workflows/action.yml +++ b/.github/workflows/action.yml @@ -132,3 +132,9 @@ jobs: path: | ./**/*.log ./**/out*.meta + + - uses: actions/upload-artifact@v4 + if: ${{ !cancelled() }} + with: + name: flac-${{ github.run_id }}-${{ github.sha }} + path: flac From 0a72d232e284fb75acc85530ce1da66e87b3a33d Mon Sep 17 00:00:00 2001 From: dofuuz <8174871+dofuuz@users.noreply.github.com> Date: Wed, 19 Feb 2025 10:45:01 +0900 Subject: [PATCH 2/2] Fix artifact --- .github/workflows/action.yml | 9 ++++++--- .github/workflows/msys2.yml | 1 + .github/workflows/options.yml | 9 ++++++++- 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/.github/workflows/action.yml b/.github/workflows/action.yml index 9ca5fbab9c..d3f016f3e5 100644 --- a/.github/workflows/action.yml +++ b/.github/workflows/action.yml @@ -91,6 +91,7 @@ jobs: ./autogen.sh ./configure ${{ matrix.configure-opts }} make + make DESTDIR=$(pwd)/flac install make check - name: Prepare CMake build directory @@ -114,7 +115,9 @@ jobs: CC: ${{ matrix.cc }} CXX: ${{ matrix.cxx }} working-directory: cmake-build - run: cmake --build . --config Release + run: | + cmake --build . --config Release + cmake --install . --prefix ../flac --config Release - name: CMake test if: startsWith(matrix.build-system,'cmake') @@ -128,7 +131,7 @@ jobs: uses: actions/upload-artifact@v4 if: failure() with: - name: flac-${{ github.sha }}-${{ github.run_id }}-logs + name: flac-${{ matrix.name }}-${{ github.sha }}-${{ github.run_id }}-logs path: | ./**/*.log ./**/out*.meta @@ -136,5 +139,5 @@ jobs: - uses: actions/upload-artifact@v4 if: ${{ !cancelled() }} with: - name: flac-${{ github.run_id }}-${{ github.sha }} + name: flac-${{ matrix.name }}-${{ github.sha }} path: flac diff --git a/.github/workflows/msys2.yml b/.github/workflows/msys2.yml index f8331f23cd..460ffadab5 100644 --- a/.github/workflows/msys2.yml +++ b/.github/workflows/msys2.yml @@ -49,6 +49,7 @@ jobs: - name: Package build uses: actions/upload-artifact@v4 + if: ${{ !cancelled() }} with: name: flac-win64-static-${{ github.sha}} path: flac diff --git a/.github/workflows/options.yml b/.github/workflows/options.yml index 1bfa27debd..ef65c15dff 100644 --- a/.github/workflows/options.yml +++ b/.github/workflows/options.yml @@ -42,13 +42,20 @@ jobs: ./autogen.sh ./configure --disable-thorough-tests ${{ matrix.configure-opts }} make + make DESTDIR=$(pwd)/flac install make check - name: Upload logs on failure uses: actions/upload-artifact@v4 if: failure() with: - name: flac-${{ github.sha }}-${{ github.run_id }}-logs + name: flac-${{ matrix.name }}-${{ github.sha }}-${{ github.run_id }}-logs path: | ./**/*.log ./**/out*.meta + + - uses: actions/upload-artifact@v4 + if: ${{ !cancelled() }} + with: + name: flac-${{ matrix.name }}-${{ github.sha }} + path: flac