Let's scale our maximum attenuation correctly...

GregorR · GregorR · commit 6168a4975e09 · 2018-09-20T21:59:55.000-04:00
diff --git a/src/denoise.c b/src/denoise.c
@@ -546,11 +546,10 @@ float rnnoise_process_frame(DenoiseState *st, float *out, const float *in) {
       if (min < st->max_attenuation) {
         if (min < MIN_MAX_ATTENUATION)
           min = MIN_MAX_ATTENUATION;
-        mult = st->max_attenuation / min;
+        mult = (1.0f-st->max_attenuation) / (1.0f-min);
         for (i=0;i<NB_BANDS;i++) {
           if (g[i] < MIN_MAX_ATTENUATION) g[i] = MIN_MAX_ATTENUATION;
-          g[i] *= mult;
-          if (g[i] > 1) g[i] = 1;
+          g[i] = 1.0f-((1.0f-g[i]) * mult);
           st->lastg[i] = g[i];
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -546,11 +546,10 @@ float rnnoise_process_frame(DenoiseState st, float out, const float *in) {`
`546`	`546`	`if (min < st->max_attenuation) {`
`547`	`547`	`if (min < MIN_MAX_ATTENUATION)`
`548`	`548`	`min = MIN_MAX_ATTENUATION;`
`549`		`- mult = st->max_attenuation / min;`
	`549`	`+ mult = (1.0f-st->max_attenuation) / (1.0f-min);`
`550`	`550`	`for (i=0;i<NB_BANDS;i++) {`
`551`	`551`	`if (g[i] < MIN_MAX_ATTENUATION) g[i] = MIN_MAX_ATTENUATION;`
`552`		`- g[i] *= mult;`
`553`		`- if (g[i] > 1) g[i] = 1;`
	`552`	`+ g[i] = 1.0f-((1.0f-g[i]) * mult);`
`554`	`553`	`st->lastg[i] = g[i];`
`555`	`554`	`}`
`556`	`555`	`}`