Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SRV and TXT in custom DNS zones #1588

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

Terrance
Copy link
Contributor

Fixes #1587.

I wonder if there's a better way to do this more generically, but for now I've just added SRV and TXT explicitly, tests included.

@kwitsch kwitsch added the 🔨 enhancement New feature or request label Aug 26, 2024
@kwitsch kwitsch added this to the v0.25 milestone Aug 26, 2024
@kwitsch
Copy link
Collaborator

kwitsch commented Aug 26, 2024

Thanks for the contribution. 👍

If you fix the failing workflows I'll merge it.

@Terrance
Copy link
Contributor Author

Ah, I saw the option to format but not lint as it wasn't set up as a VSCode build task. Should hopefully be happy now.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.03%. Comparing base (fe84ab8) to head (1f2bb00).
Report is 118 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1588      +/-   ##
==========================================
+ Coverage   93.88%   94.03%   +0.14%     
==========================================
  Files          78       79       +1     
  Lines        6361     5078    -1283     
==========================================
- Hits         5972     4775    -1197     
+ Misses        300      213      -87     
- Partials       89       90       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kwitsch
Copy link
Collaborator

kwitsch commented Aug 26, 2024

Ah, I saw the option to format but not lint as it wasn't set up as a VSCode build task. Should hopefully be happy now.

I forgot to add it, sorry about that. 🫣

Copy link
Collaborator

@kwitsch kwitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kwitsch kwitsch merged commit 4eff0b3 into 0xERR0R:main Aug 26, 2024
11 checks passed
@Terrance Terrance deleted the custom-dns-rr-types branch August 27, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for additional record types in customDNS.zone
2 participants