Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Reduced length of deployment name #3046

Conversation

mVermaat
Copy link
Contributor

Description

Deployment names are limited to 64 characters. These names are very long and leaving only a small portion of the name the name of the database. The default name is already 39 characters, leaving only 25 characters for the name of the database. This change simply reduces it to 26 characters, leaving 38 characters for the database name. and therfor granting more flexibility.

The provided deployment name 'dfrl2mpjuwzn4-{dbname}-shortTermBackupRetention' has a length of '65' which exceeds the maximum length of '64'. 

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My code follows the style guidelines of this project
  • I did format my code

@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Mar 24, 2023
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution @mVermaat

@AlexanderSehr AlexanderSehr merged commit f0a9372 into Azure:main Mar 24, 2023
@AlexanderSehr AlexanderSehr changed the title Reduced length of deployment name [Modules] Reduced length of deployment name Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants