Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve yaml parsing ++ #313

Merged
merged 39 commits into from
Oct 29, 2021
Merged

Improve yaml parsing ++ #313

merged 39 commits into from
Oct 29, 2021

Conversation

MariusStorhaug
Copy link
Contributor

@MariusStorhaug MariusStorhaug commented Oct 29, 2021

Change

Validate changes here:
Consumption: Budgets

.github/actions/templates/getWorkflowInput/scripts/Get-WorkflowDefaultInput.ps1

  • Update to convert yaml to object via a module called powershell-yaml. This supported converting raw yaml input to object. This replaces the current string manipulation/parsing to get values.
  • Fixed bug to allow for verbose output.

.github/actions/sharedScripts/Set-EnvironmentOnAgent.ps1

  • Commented out installations that are already installed on the GitHub hosted runners, such as Bicep CLI, AzCLI+DevOps extension. Now only displays installed versions.

Other:

  • Updated global test to correctly display resource being tested in brackets [Microsoft.Provider/ResourceType] at the start of the line.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@github-actions
Copy link

github-actions bot commented Oct 29, 2021

Unit Test Results

  1 files  ±0  1 suites  ±0   14s ⏱️ -1s
  1 tests  - 2  1 ✔️  - 2    0 💤 ±0  0 ±0 
32 runs   - 2  1 ✔️  - 2  31 💤 ±0  0 ±0 

Results for commit 4d3db43. ± Comparison against base commit 6ae0ca0.

This pull request removes 3 and adds 1 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [] used resource type [healthBots] should use on of the recent API version(s). Currently using [2020-12-08]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [] used resource type [locks] should use on of the recent API version(s). Currently using [2016-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2020-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Consumption/budgets] used resource type [budgets] should use on of the recent API version(s). Currently using [2019-05-01]

♻️ This comment has been updated with latest results.

@MariusStorhaug MariusStorhaug changed the title Parse yaml Improve yaml parsing Oct 29, 2021
@MariusStorhaug MariusStorhaug marked this pull request as ready for review October 29, 2021 16:31
@MariusStorhaug MariusStorhaug changed the title Improve yaml parsing Improve yaml parsing ++ Oct 29, 2021
@AlexanderSehr AlexanderSehr added bug Something isn't working enhancement New feature or request labels Oct 29, 2021
@AlexanderSehr AlexanderSehr added this to the MVP milestone Oct 29, 2021
@MariusStorhaug MariusStorhaug merged commit 81af99c into main Oct 29, 2021
@MariusStorhaug MariusStorhaug deleted the ParseYAML branch October 29, 2021 21:14
@MariusStorhaug MariusStorhaug linked an issue Oct 29, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug fix - workflow file parser
3 participants