Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed markdown gen #316

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Fixed markdown gen #316

merged 1 commit into from
Oct 30, 2021

Conversation

AlexanderSehr
Copy link
Contributor

Change

  • Fixed a bug in the module table generation where it would not correctly filter 'actual' modules.
  • The error only occured with storage account & CosmosDB/DocumentDB due to their new format

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr self-assigned this Oct 30, 2021
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 30, 2021 07:50
@AlexanderSehr AlexanderSehr added the bug Something isn't working label Oct 30, 2021
@AlexanderSehr AlexanderSehr added this to the MVP milestone Oct 30, 2021
MariusStorhaug
MariusStorhaug approved these changes Oct 30, 2021
View reviewed changes
Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments. Seem to be working.

@AlexanderSehr AlexanderSehr merged commit f33a54b into main Oct 30, 2021
@MariusStorhaug MariusStorhaug deleted the users/alsehr/markDownGenFix branch October 30, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusStorhaug MariusStorhaug MariusStorhaug approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
bug Something isn't working
Projects
None yet
Milestone
MVP
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderSehr @MariusStorhaug