Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated expressRouteCircuits module with Local tier #358

Merged

Conversation

torivara
Copy link
Contributor

@torivara torivara commented Nov 3, 2021

Change

Added Local to list of allowed tiers on expressRouteCircuits skuTier parameters. Could not choose Local when testing this module locally ( #357 ). This change adds the possibility for setting Local as a Sku Tier.

Also added some logic on the skuFamily property, because Local setting only allows Unlimited data.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ghost
Copy link

ghost commented Nov 3, 2021

CLA assistant check
All CLA requirements met.

@torivara
Copy link
Contributor Author

torivara commented Nov 3, 2021

I also noticed in the Getting Started guide, there is no option for those only wanting to contribute code changes. There should be an "Option 4: For those that only want to contribute code changes", or something similar.

@AlexanderSehr
Copy link
Contributor

Hey @torivara , thanks for the contribution. Good catch & thanks for not only creating the issue but implementing the solution too. There'd be a 'basic' SKU as well, but I'll create another issue for that one.
Same for the docs, thanks for pointing this out

@AlexanderSehr AlexanderSehr linked an issue Nov 3, 2021 that may be closed by this pull request
@AlexanderSehr
Copy link
Contributor

Created issue #359

@AlexanderSehr AlexanderSehr merged commit c69e175 into Azure:main Nov 3, 2021
@AlexanderSehr
Copy link
Contributor

Approved & merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expressRouteCircuits does not support 'Local' sku_tier
2 participants