Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing AVD and storage #366

Merged
merged 25 commits into from
Nov 3, 2021
Merged

Fixing AVD and storage #366

merged 25 commits into from
Nov 3, 2021

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Nov 3, 2021

Change

  • Adding AVD dependencies to dependency pipeline
  • Fixing AVD modules to reference dependencies
  • Replacing AVD modules "name" parameter
  • Move tested AVD location to weu
  • Fixing storage to deploy private containers

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

Erika Gressi and others added 25 commits October 25, 2021 09:53
* test workflow template

* fix policy assignment to accept westeu

* test trigger output

* test trigger output

* test trigger output context

* test trigger set get

* test trigger set get

* test trigger set get set out

* test trigger set get set out single

* test trigger set get set out singles

* test trigger output between jobs

* test trigger output between jobs if else

* test trigger output between jobs if else write-host

* test trigger output between jobs if else write-host condition

* test trigger output between jobs if else write-host conditions

* remove if else

* comment if else

* comment else

* comment else

* set input var

* set input var event_name

* set input var event_name 01

* set input var event_name if

* set input var event_name if

* set input var event_name if

* set input var event_name if print

* out removeDeployment

* echo removeDeployment

* echo removeDeployment check else

* echo removeDeployment set before else

* echo removeDeployment set before else condition

* echo removeDeployment set before else condition par

* condition par

* condition quote

* if else and output

* convert from yaml

* convert from yaml templatefile

* convert from yaml templatefile

* env.workflowpath

* cleanup

* checkout back

* action

* 1 action

* 1 action no param

* 1 action yes param

* 1 action yes param 1

* 1 action yes param 2

* no action from push

* action from push

* action from push rename

* action from push if

* action from push if spaces

* cleanup

* env

* input

* input

* apace

* inputs

* main run

* analisys services

* analisys services comment actions

* analisys services uncomment actions

* analisys services comment test actions

* analisys services uncomment

* cleanup

* refactor

* uncomment for push

* script out

* cleanup

* cleanup

* avset bicep

* avset bicep workflow name

* avset bicep readme

* avset bicep push

* proximity placement group

* lowercase workflow

* temp change

* change back

* dependency pipeline

* dependency pipeline param

* dependency pipeline param list

* msi param list

* msi job name

* nsg

* clean nsg from flowlogs

* workflow rename

* workflow rename push path

* remove dependencies rg

* sa evhns

* sa evhns law pipeline

* pip

* sig

* pip param name

* level1

* kv

* unique names

* access policies

* remove set keys

* evh

* skip removal soft delete

Co-authored-by: Erika Gressi <erikag.microsoft.com>
@eriqua eriqua added this to the v 0.3 milestone Nov 3, 2021
@eriqua eriqua self-assigned this Nov 3, 2021
@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Unit Test Results

  1 files  ±0  1 suites  ±0   15s ⏱️ -1s
  4 tests +3  4 ✔️ +3    0 💤 ±0  0 ±0 
35 runs  +3  4 ✔️ +3  31 💤 ±0  0 ±0 

Results for commit 0637f28. ± Comparison against base commit 7a8273f.

This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be &#x27;recent&#x27;].In [Microsoft.ApiManagement/serviceResources/authorizationServers] used resource type [service/authorizationServers] should use on of the recent API version(s). Currently using [2020-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be &#x27;recent&#x27;].In [Microsoft.DesktopVirtualization/workspaces] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2017-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be &#x27;recent&#x27;].In [Microsoft.DesktopVirtualization/workspaces] used resource type [locks] should use on of the recent API version(s). Currently using [2016-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be &#x27;recent&#x27;].In [Microsoft.DesktopVirtualization/workspaces] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be &#x27;recent&#x27;].In [Microsoft.DesktopVirtualization/workspaces] used resource type [workspaces] should use on of the recent API version(s). Currently using [2021-07-12]

♻️ This comment has been updated with latest results.

@eriqua eriqua merged commit 00fcc07 into main Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants