RSV Child Resource Rework #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a line in the gitIgnore file to ignore Backup/*. As a result, new folders labeled backup were not being tracked. This has been fixed and the rest of the child resources have been pushed.
* Child Resource Re-Work for RSV * Child Resource Re-Work for RSV + Update gitIgnore There was a line in the gitIgnore file to ignore Backup/*. As a result, new folders labeled backup were not being tracked. This has been fixed and the rest of the child resources have been pushed. * Update allowed parameters and parameter file * Update RSV ReaUpdate RSV ReadMe FilesdMe Files
This reverts commit 694738a.
eriqua
reviewed
Nov 10, 2021
eriqua
requested changes
Nov 10, 2021
arm/Microsoft.RecoveryServices/vaults/backupPolicies/deploy.bicep
Outdated
Show resolved
Hide resolved
arm/Microsoft.RecoveryServices/vaults/backupPolicies/deploy.bicep
Outdated
Show resolved
Hide resolved
arm/Microsoft.RecoveryServices/vaults/backupStorageConfig/deploy.bicep
Outdated
Show resolved
Hide resolved
arm/Microsoft.RecoveryServices/vaults/backupStorageConfig/deploy.bicep
Outdated
Show resolved
Hide resolved
arm/Microsoft.RecoveryServices/vaults/protectionContainers/deploy.bicep
Outdated
Show resolved
Hide resolved
arm/Microsoft.RecoveryServices/vaults/protectionContainers/deploy.bicep
Outdated
Show resolved
Hide resolved
arm/Microsoft.RecoveryServices/vaults/protectionContainers/deploy.bicep
Outdated
Show resolved
Hide resolved
eriqua
reviewed
Nov 11, 2021
eriqua
requested changes
Nov 11, 2021
arm/Microsoft.RecoveryServices/vaults/.parameters/parameters.json
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Refactored the RSV module to align with the new Child-Resource structure
Type of Change
Please delete options that are not relevant.
Checklist