Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled bicep in pipelines #54

Merged
merged 90 commits into from
Sep 27, 2021
Merged

Enabled bicep in pipelines #54

merged 90 commits into from
Sep 27, 2021

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Sep 24, 2021

Change

  • Update module tests to work with bicep
  • Refactored several modules to work with tests
  • Refactored pipeline actions to work with bicep
  • Added bicep cli installation
  • Added conditional template spec publishing workaround
  • Fixed some bicep template issues
  • Switched pipeline login to native action

    NOTE: This requires an update of the current credentials

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 24, 2021 22:55
@ahmadabdalla
Copy link
Contributor

@MrMCake , do you think it's worth parameterizing the 'deploymentScope', making it more targeted. Thus, reducing lines 123-145?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants