Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bicep template for automation account #91

Merged
merged 23 commits into from
Oct 3, 2021
Merged

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Oct 1, 2021

Change

  • Bicep template for automation account leveraging logic for

    • child resources (runbooks, schedules, jobschedules)
    • locks
    • diagnostic settings
    • rbac
    • private endpoint
  • Including following improvements wrt the ARM template

    • Adding modules resources reusing this
    • Only relevant azure roles
    • Adding output for modules and runbooks
  • Minor fix typo in rsv module

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr
Copy link
Contributor

Please add updates to the readme.md

@AlexanderSehr
Copy link
Contributor

Please change the pipeline file to reference the deploy.bicep instead of deploy.json

Copy link
Contributor

@segraef segraef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far so good 👋🏽

@eriqua eriqua enabled auto-merge (squash) October 2, 2021 15:10
@eriqua eriqua merged commit 11d529a into Azure:main Oct 3, 2021
@eriqua eriqua deleted the automationAccounts branch October 25, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants