Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default secure values for storage accounts #920

Merged
merged 27 commits into from
Jan 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
2dff5dd
Updated key vault
elenabatanero Dec 13, 2021
658d43c
removed default value for attributesExp param within Key and secret s…
elenabatanero Dec 14, 2021
4f47bd1
Updated key vault
elenabatanero Dec 15, 2021
bef382d
Merge branch 'main' into users/elanzelm/keyvault
elenabatanero Dec 15, 2021
349f9f7
Testing parameters
elenabatanero Dec 15, 2021
9b24c5f
Updated key vault with security recommendations
elenabatanero Jan 17, 2022
1d432ce
upodated key vault with security recommendations
elenabatanero Jan 17, 2022
5cde128
Merge remote-tracking branch 'origin/main' into users/elanzelm/keyvault
elenabatanero Jan 17, 2022
0042b47
Update arm/Microsoft.KeyVault/vaults/.parameters/parameters.json
elbatane Jan 17, 2022
7cfa737
Update arm/Microsoft.KeyVault/vaults/secrets/readme.md
elbatane Jan 18, 2022
87b9fa2
Update arm/Microsoft.KeyVault/vaults/readme.md
elbatane Jan 18, 2022
6af1df8
Update arm/Microsoft.KeyVault/vaults/readme.md
elbatane Jan 18, 2022
2956eae
Update arm/Microsoft.KeyVault/vaults/readme.md
elbatane Jan 18, 2022
27e628f
Update arm/Microsoft.KeyVault/vaults/readme.md
elbatane Jan 18, 2022
9f3905e
Update arm/Microsoft.KeyVault/vaults/readme.md
elbatane Jan 18, 2022
848fef5
Update arm/Microsoft.KeyVault/vaults/keys/readme.md
elbatane Jan 18, 2022
dcb9db1
reformatting outputs readme
elenabatanero Jan 18, 2022
217d54a
Updated params descriptions and readme according to comments
elenabatanero Jan 18, 2022
ba36eaf
storage account security
elanzel Jan 21, 2022
32faf5f
requireInfrastructureEncryption
elanzel Jan 21, 2022
0c26580
readme update
elanzel Jan 21, 2022
82c3d76
requireInfrastructureEncryption
elanzel Jan 22, 2022
18d9b14
requireInfrastructureEncryption param
elanzel Jan 22, 2022
76e9f2b
dependency vnet name update
elanzel Jan 22, 2022
9cf1663
sxx-az-subnet-x-005-privateEndpoints param
elanzel Jan 22, 2022
5f4e5d0
Merge branch 'main' of https://github.com/Azure/ResourceModules into …
elanzel Jan 24, 2022
0e8998f
default security values set
elanzel Jan 24, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,37 @@
"allowBlobPublicAccess": {
"value": false
},
"requireInfrastructureEncryption": {
"value": true
},
"privateEndpoints": {
"value": [
{
"subnetResourceId": "/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/adp-sxx-az-vnet-x-001/subnets/sxx-az-subnet-x-005-privateEndpoints",
"service": "blob"
},
{
"subnetResourceId": "/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/adp-sxx-az-vnet-x-001/subnets/sxx-az-subnet-x-005-privateEndpoints",
"service": "table"
},
{
"subnetResourceId": "/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/adp-sxx-az-vnet-x-001/subnets/sxx-az-subnet-x-005-privateEndpoints",
"service": "queue"
},
{
"subnetResourceId": "/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/adp-sxx-az-vnet-x-001/subnets/sxx-az-subnet-x-005-privateEndpoints",
"service": "file"
}
]
},
"networkAcls": {
"value": {
"bypass": "AzureServices",
"defaultAction": "Deny",
"virtualNetworkRules": [],
"ipRules": []
}
},
"blobServices": {
"value": {
"diagnosticLogsRetentionInDays": 7,
Expand Down
12 changes: 8 additions & 4 deletions arm/Microsoft.Storage/storageAccounts/deploy.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,18 @@ param azureFilesIdentityBasedAuthentication object = {}
@description('Optional. Virtual Network Identifier used to create a service endpoint.')
param vNetId string = ''

@description('Optional. Configuration Details for private endpoints.')
@description('Optional. Configuration Details for private endpoints. For security reasons, it is recommended to use private endpoints whenever possible')
param privateEndpoints array = []

@description('Optional. The Storage Account ManagementPolicies Rules.')
param managementPolicyRules array = []

@description('Optional. Networks ACLs, this value contains IPs to whitelist and/or Subnet information.')
@description('Optional. Networks ACLs, this value contains IPs to whitelist and/or Subnet information. For security reasons, it is recommended to set the DefaultAction Deny')
param networkAcls object = {}

@description('Optional. A boolean indicating whether or not the service applies a secondary layer of encryption with platform managed keys for data at rest. For security reasons, it is recommended to set it to true.')
param requireInfrastructureEncryption bool = true

@description('Optional. Blob service and containers to deploy')
param blobServices object = {}

Expand All @@ -71,8 +74,8 @@ param queueServices object = {}
@description('Optional. Table service and tables to create.')
param tableServices object = {}

@description('Optional. Indicates whether public access is enabled for all blobs or containers in the storage account.')
param allowBlobPublicAccess bool = true
@description('Optional. Indicates whether public access is enabled for all blobs or containers in the storage account. For security reasons, it is recommended to set it to false.')
param allowBlobPublicAccess bool = false

@allowed([
'TLS1_0'
Expand Down Expand Up @@ -166,6 +169,7 @@ var saBaseProperties = {
minimumTlsVersion: minimumTlsVersion
networkAcls: (empty(networkAcls) ? null : networkAcls_var)
allowBlobPublicAccess: allowBlobPublicAccess
requireInfrastructureEncryption: requireInfrastructureEncryption
}
var saOptIdBasedAuthProperties = {
azureFilesIdentityBasedAuthentication: azureFilesIdentityBasedAuthentication_var
Expand Down
3 changes: 2 additions & 1 deletion arm/Microsoft.Storage/storageAccounts/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ This module is used to deploy a storage account, with the ability to deploy 1 or

| Parameter Name | Type | Default Value | Possible Values | Description |
| :-- | :-- | :-- | :-- | :-- |
| `allowBlobPublicAccess` | bool | `True` | | Optional. Indicates whether public access is enabled for all blobs or containers in the storage account. |
| `allowBlobPublicAccess` | bool | `False` | | Optional. Indicates whether public access is enabled for all blobs or containers in the storage account. For security reasons, it is recommended to set it to false. |
| `requireInfrastructureEncryption` | boolean | `True` | | Optional. A boolean indicating whether or not the service applies a secondary layer of encryption with platform managed keys for data at rest. For security reasons, it is recommended to set it to true. |
| `azureFilesIdentityBasedAuthentication` | object | `{object}` | | Optional. Provides the identity based authentication settings for Azure Files. |
| `basetime` | string | `[utcNow('u')]` | | Generated. Do not provide a value! This date value is used to generate a SAS token to access the modules. |
| `blobServices` | _[blobServices](blobServices/readme.md)_ object | `{object}` | | Optional. Blob service and containers to deploy |
Expand Down