Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/alsehr/bicep vwan #95

Merged
merged 6 commits into from
Oct 3, 2021
Merged

Users/alsehr/bicep vwan #95

merged 6 commits into from
Oct 3, 2021

Conversation

AlexanderSehr
Copy link
Contributor

Change

  • Added tested VWAN bicep module
  • NOTE: The removal needs custom logic to function. The pipeline will remain red for now and we need to manualy clean up.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 3, 2021 11:58
Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review the comments.

Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, as my comments are solved.

@AlexanderSehr AlexanderSehr merged commit 8f5fe6a into main Oct 3, 2021
@AlexanderSehr AlexanderSehr deleted the users/alsehr/bicep_vwan branch October 3, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants