[WIP] POC CustomEvents #48378
Draft
[WIP] POC CustomEvents #48378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
| var properties = new ChangeTrackingDictionary<string, string>(); | ||
| ProcessLogRecordProperties(logRecord, properties, out string? message, out string? eventName); | ||
|
|
||
| if (message is not null && logRecord.Exception is not null) |
There was a problem hiding this comment.
If logRecord is exception we don't need to have additional check on CustomEventAttributeName and could use the existing implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this Draft PR to collect feedback.
If we're good with this overall approach, I need to finish updating all the tests that relied on the old behavior.
Before
In the current implementation,
LogsHelper.OtelToAzureMonitorLogsinspects a few top-level properties and then decides if a telemetry item is an AI-Trace or Exception. Then the Data classes will callLogsHelper.GetMessageAndSetPropertiesto parse all LogRecord Attributes.After
Moving forward, we need to evaluate LogRecord.Attributes earlier so we can determine if the telemetry item is a Custom Event.
LogsHelper.OtelToAzureMonitorLogswas refactored.LogsHelper.GetMessageAndSetPropertieswas changed toLogsHelper.ProcessLogRecordProperties.