Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Debug implementation of Binary to hex #1201

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Conversation

webmaster128
Copy link
Member

Closes #1199

Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the 0x prefix would make sense to make it immediately obvious it's a hex representation.

Good otherwise!

@webmaster128
Copy link
Member Author

I wonder if the 0x prefix would make sense to make it immediately obvious it's a hex representation.

I was tinking about this as well and implemented it initially. But then though it is just noise and also if you double click to select, you get the whole string including 0x, which you cannot process in other tools.

But no strong opinion here.

@uint
Copy link
Contributor

uint commented Jan 17, 2022

But no strong opinion here.

No strong opinion here either. I trust your gut!

@webmaster128 webmaster128 merged commit d450501 into main Jan 17, 2022
@webmaster128 webmaster128 deleted the debug-binary-as-hex branch January 17, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better Debug encoding for Binary
2 participants