Refactor _validate_data_input to simplify the codes #3818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
force-pushed
the
refactor/validate_data_input
branch
from
e4cc57d to
9672f05
Compare
seisman
changed the title
seisman
commented
Feb 22, 2025
Comment on lines
+137
to
+112
| # Determine the required number of columns based on the required_z flag. | ||
| required_cols = 3 if required_z else 1 |
There was a problem hiding this comment.
Most modules usually requires 2 columns but there are exceptions like histogram and info will works for 1 column. So the default value is 1 if required_z is False.
Will refactor this part in PR #3369
seisman
added
maintenance
seisman
force-pushed
the
refactor/validate_data_input
branch
from
9672f05 to
839caa1
Compare
seisman
force-pushed
the
refactor/validate_data_input
branch
from
ccb74d0 to
963c9ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid nested if-else statements in the
_validate_data_inputfunction. Instead, checking the data based on the data kind using match-case statements.