build(deps-dev): bump rubocop-performance from 1.23.1 to 1.24.0 in /Library/Homebrew #19329
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dduugg
force-pushed
the
dependabot/bundler/Library/Homebrew/rubocop-performance-1.24.0
branch
from
322f27c to
16e0269
Compare
Bumps [rubocop-performance](https://github.com/rubocop/rubocop-performance) from 1.23.1 to 1.24.0. - [Release notes](https://github.com/rubocop/rubocop-performance/releases) - [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-performance@v1.23.1...v1.24.0) --- updated-dependencies: - dependency-name: rubocop-performance dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dduugg
force-pushed
the
dependabot/bundler/Library/Homebrew/rubocop-performance-1.24.0
branch
from
b62cba6 to
e098307
Compare
Library/Homebrew/aliases/alias.rb
Outdated
| @@ -18,7 +18,10 @@ def initialize(name, command = nil) | |||
| @symlink = T.let(nil, T.nilable(Pathname)) | |||
|
|
|||
| @command = if command&.start_with?("!", "%") | |||
| # `drop` is not defined on `String` | |||
| # rubocop:disable Performance/ArraySemiInfiniteRangeSlice | |||
There was a problem hiding this comment.
This isn't supposed to be enabled. Upstream actually states:
This cop was created due to a mistake in microbenchmark and hence is disabled by default
Given the large amount of fixes in this PR in a version bump that is supposed to only have one extra cop, it seems like something's very broken here and cop violations here should not be trusted until we get that fixed.
There was a problem hiding this comment.
Ah, good catch. I think the default config is only loaded when the cop is a plugin: rubocop/rubocop-performance@v1.23.1...v1.24.0#diff-5a022e7952dfb32fcbdce1db566fce92f11071753c6ce2b60c09f5a0edf8b6fc
Unfortunately, I'm not able to follow the plugin migration suggested by the docs due to: rubocop/rubocop-rspec#2048 (comment)
Library/Homebrew/warnings.rb
Outdated
| return unless block_given? | ||
| return unless block |
There was a problem hiding this comment.
This cop produces code with significantly worse performance when a block is being passed to the method and as such should not be enabled.
dduugg
force-pushed
the
dependabot/bundler/Library/Homebrew/rubocop-performance-1.24.0
branch
from
e098307 to
e26f6ea
Compare
Bumps rubocop-performance from 1.23.1 to 1.24.0.
Release notes
Sourced from rubocop-performance's releases.
Changelog
Sourced from rubocop-performance's changelog.
Commits
24a3a4eCut 1.24.020c07a2Update Changelogf6e7da0Merge pull request #490 from koic/pluginfy_with_lint_rollerb83339dPluginfy RuboCop Performanceab7ef16Suppress redundant configuration logging for rubocop-performace2c00726Avoid unnecessarysend074bd2aExplicit defaultPerformance/Sumcop config for the spec349ae04Suppress RuboCop's offenses2d36cacMerge pull request #462 from corsonknowles/add_performance_use_zip_to_wrap_ar...063b56dMerge pull request #489 from dvandersluis/use-node-groupsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)