Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/bottle: check for prefix when not /usr/local #19357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Feb 23, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes incorrectly marking bottles as relocatable, e.g.

https://github.com/Homebrew/homebrew-core/blob/425d4ea43d36e7d03ce894268dd42aef5236bb54/Formula/p/pkgconf.rb#L34-L36

This cannot be done for /usr/local as it is used outside Homebrew. Other default prefixes are Homebrew-specific.

Fixes incorrectly marking bottles as relocatable, e.g.

https://github.com/Homebrew/homebrew-core/blob/425d4ea43d36e7d03ce894268dd42aef5236bb54/Formula/p/pkgconf.rb#L34-L36

This cannot be done for `/usr/local` as it is used outside Homebrew.
Other default prefixes are Homebrew-specific.
@cho-m cho-m force-pushed the relocatable-check-prefix branch from eda8be4 to 05d3ce8 Compare February 23, 2025 19:28
@cho-m cho-m marked this pull request as ready for review February 23, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant