fix(sql): updating the values to not be pointers when added to the args slice #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This pull request includes changes to the
inserter/sql.go
andinserter/sql_test.go
files to improve the handling of pointer types and simplify the test assertions. The most important changes include updating thegetFieldValue
method to handle non-nil pointers correctly and replacings.Require
assertions withs
assertions in the test suite.Improvements to pointer handling:
inserter/sql.go
: Updated thegetFieldValue
method to handle non-nil pointers by returning the dereferenced value.Simplification of test assertions:
inserter/sql_test.go
: Replaceds.Require().Len
withs.Len
in multiple test functions to simplify the assertions. [1] [2] [3] [4] [5] [6] [7] [8] [9]inserter/sql_test.go
: Replaceds.Require().NoError
withs.NoError
ands.Require().Equal
withs.Equal
in thegenerateSQLSuite
test functions to simplify the assertions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]