Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): updating the values to not be pointers when added to the args slice #124

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

Jacobbrewer1
Copy link
Owner

Describe your changes

This pull request includes changes to the inserter/sql.go and inserter/sql_test.go files to improve the handling of pointer types and simplify the test assertions. The most important changes include updating the getFieldValue method to handle non-nil pointers correctly and replacing s.Require assertions with s assertions in the test suite.

Improvements to pointer handling:

  • inserter/sql.go: Updated the getFieldValue method to handle non-nil pointers by returning the dereferenced value.

Simplification of test assertions:

@Jacobbrewer1 Jacobbrewer1 enabled auto-merge (squash) February 17, 2025 13:55
@Jacobbrewer1 Jacobbrewer1 merged commit 3ca1165 into main Feb 17, 2025
6 checks passed
@Jacobbrewer1 Jacobbrewer1 deleted the fix/pointer-values branch February 17, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant