Add support for decisions that take no action #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area
force-pushed
the
feat/simple-decisions
branch
from
5348c4d to
d128a8b
Compare
area
force-pushed
the
feat/simple-decisions
branch
from
d128a8b to
42bcede
Compare
|
My first comment here is you bought up the idea of having this be a separate extension, so colonies can choose to install these individually. Is this just a prototype implementation for feedback, or do you want to keep the functionality bundled? |
|
See my comment on #1068 |
area
force-pushed
the
feat/simple-decisions
branch
from
42bcede to
7d16570
Compare
area
force-pushed
the
feat/simple-decisions
branch
from
7d16570 to
56df1f6
Compare
area
force-pushed
the
feat/simple-decisions
branch
from
69cd0f8 to
1051dcf
Compare
kronosapiens
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
I'd actually be inclined to call the function finalizable() because in ~most cases it returns the Finalized state, and so would make getMotionState read a bit better. The intended state in those branches is Finalizable except for this new exception, so Id' say we could justify tucking that exception away in the finalizable function for people who are curious. But I'll leave that up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1068.
Not happy with the ternary, would very much like a function with a more understandable if statement, but can't come up with a semantic name for that function beyond
finalizableOrFinalized. Please suggest something!Should the 'special action' be longer than just a signature? Obviously it's all meaningless, but...