Make metatransaction broadcaster estimateGas call stricter #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area
force-pushed
the
maint/metatx-gas-limit
branch
from
b0b9551 to
424c804
Compare
kronosapiens
approved these changes
Jul 29, 2022
| } catch (err) { | ||
| return res.status(400).send({ | ||
| status: "fail", | ||
| data: { | ||
| payload: "Transaction reverts and will not be broadcast", | ||
| payload: "Transaction reverts and will not be broadcast. It either fails outright, or uses too much gas.", |
There was a problem hiding this comment.
I'm inclined to suggest we save all error messages to variables and use the variables here, but it's little more than a vague notion so I'll just let you think about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some spotty tests came down to some behaviour here, where the oracle took a long time to responsd, and on thinking about it it did raise a potential issue with the broadcaster, so have decided to change its behaviour slightly (already cleared with the frontend). By including the gas limit with
estimateGas, we return as quickly as possible. We lose information about whether the transaction fails or is too expensive, but I think that's fine to prevent people deliberately trying metatransactions that use a lot of gas to slow down / DoS the oracle (which is still possible, just harder).