Add test scaffolding for cross-chain tests #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area
force-pushed
the
maint/cross-chain-safe
branch
from
a60a45a to
424fb7d
Compare
area
force-pushed
the
maint/cross-chain-safe
branch
5 times, most recently
from
3ceda73 to
a880743
Compare
area
force-pushed
the
maint/cross-chain-safe
branch
from
a880743 to
5e4f841
Compare
kronosapiens
reviewed
Mar 6, 2023
area
force-pushed
the
maint/cross-chain-safe
branch
4 times, most recently
from
be61fcd to
91e9996
Compare
area
force-pushed
the
maint/cross-chain-safe
branch
from
91e9996 to
3ca3c14
Compare
kronosapiens
previously approved these changes
Mar 9, 2023
kronosapiens
previously approved these changes
Mar 10, 2023
test/cross-chain/cross-chain.js
Outdated
| const ethersHomeSigner = new ethers.providers.JsonRpcProvider(homeRpcUrl).getSigner(); | ||
|
|
||
| before(async () => { | ||
| await exec( |
There was a problem hiding this comment.
Couldn't this be an invocation of start-bridging-environment.sh with different arguments?
area
force-pushed
the
maint/cross-chain-safe
branch
3 times, most recently
from
4969e32 to
cfd22d0
Compare
area
force-pushed
the
maint/cross-chain-safe
branch
from
cfd22d0 to
2924d86
Compare
kronosapiens
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original version of this branch was a very quick-and-dirty version to get the dev environment working for those working on cross-chain safes. I've tried to clean it up and get it in to a state that can be used for the cross-chain reputation work that's cooking.
One of the functional additions here is to do with coverage - we will want colonies on both sides being tested, so all tests related to cross-chain are run twice. Once with
solidity-coveragecovering the home chain, and once withsolidity-coveragecovering the foreign chain. This seems to work based on my limited testing, but will only become clear in a build like this once there is functionality specific to one side or the other in the colony contracts.In order for this to work, tests to do with cross-chain behaviour need to be written in a way that is agnostic to which chain
truffleis covering, hence the use ofethersthroughout the example bridging test. I can't see a way to not do that.Another practical addition is a toy bridge monitor, which is started with such tests and makes sure bridged transactions go each way. The monitor, and indeed the bridged contracts, are not suitable for production, as there are no permissions. They are modelled on the AMBs set up on Gnosis but they could be anything, in principle.